fix: replace uses of deprecated fmt::has_formatter #927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mizvekov
changed the title
mizvekov
changed the title
|
An automated preview of the documentation is available at https://927.mrdocs.prtest2.cppalliance.org/index.html |
alandefreitas
force-pushed
the
fix-deprecated-fmt-is_formattable
branch
from
3d232c2 to
87d651f
Compare
|
An automated preview of the documentation is available at https://927.mrdocs.prtest2.cppalliance.org/index.html |
Collaborator
|
I rebased your branch, but still not working. |
mizvekov
force-pushed
the
fix-deprecated-fmt-is_formattable
branch
2 times, most recently
from
465b65e to
d8a7969
Compare
|
An automated preview of the documentation is available at https://927.mrdocs.prtest2.cppalliance.org/index.html |
mizvekov
force-pushed
the
fix-deprecated-fmt-is_formattable
branch
from
d8a7969 to
03e1955
Compare
|
An automated preview of the documentation is available at https://927.mrdocs.prtest2.cppalliance.org/index.html |
use is_formattable instead. has_formatter was never a good API, since it only asked if the type has a `formatter` specialization, but a type can also be formattable if it provides an implicit conversion to a type which does. The newer API takes care of the that problem.
mizvekov
force-pushed
the
fix-deprecated-fmt-is_formattable
branch
from
03e1955 to
5d4510e
Compare
|
An automated preview of the documentation is available at https://927.mrdocs.prtest2.cppalliance.org/index.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use is_formattable instead.
has_formatter was never a good API, since it only asked if the type has a
formatterspecialization, but a type can also be formattable if it provides an implicit conversion to a type which does.The newer API takes care of the that problem.