-
Notifications
You must be signed in to change notification settings - Fork 20
feat: AsciiDoc and HTML outputs support the final specifier for classes and class templates #965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
An automated preview of the documentation is available at https://965.mrdocs.prtest2.cppalliance.org/index.html |
1 similar comment
An automated preview of the documentation is available at https://965.mrdocs.prtest2.cppalliance.org/index.html |
@alandefreitas: Of course, feel free to squash the commits. (If you do that, the first commit message should be changed, as it states that we add "final" in a comment.) |
An automated preview of the documentation is available at https://965.mrdocs.prtest2.cppalliance.org/index.html |
like `class A final;` is ill-formed (`final` can't be used on a | ||
non-defining declaration). --}} | ||
{{/unless}}{{#isSeeBelow}} { /* see-below */ }{{/isSeeBelow}}{{#if isFinal}} final{{else}};{{/if}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That still leaves the case where there are base classes.
An automated preview of the documentation is available at https://965.mrdocs.prtest2.cppalliance.org/index.html |
An automated preview of the documentation is available at https://965.mrdocs.prtest2.cppalliance.org/index.html |
1 similar comment
An automated preview of the documentation is available at https://965.mrdocs.prtest2.cppalliance.org/index.html |
An automated preview of the documentation is available at https://965.mrdocs.prtest2.cppalliance.org/index.html |
…es and class templates This was already supported in XML. In this commit, we also remove the semicolon when that would produce invalid C++ code, e.g. in class A final; or class A : B1, B2; Instead, "{ /* see-below */ }" is now always followed by a semicolon, even if the record is final and/or base classes are present. This closes issue cppalliance#963.
An automated preview of the documentation is available at https://965.mrdocs.prtest2.cppalliance.org/index.html |
No description provided.