Skip to content

fix newlib #1255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
MacroModel wants to merge 3 commits into
base: next
Choose a base branch
from
Open

fix newlib #1255

MacroModel wants to merge 3 commits into from

Conversation

@MacroModel
Copy link
Collaborator

@MacroModel MacroModel commented Jan 8, 2026

No description provided.

trcrsired
trcrsired reviewed Jan 8, 2026
View reviewed changes
Copy link
Member

@trcrsired trcrsired left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// std
#include
#include
#include
#include
#include
#include <type_traits>

chrono is NOT allowed since it is not freestanding

@MacroModel
Copy link
Collaborator Author

MacroModel commented Jan 8, 2026

// std #include #include #include #include #include #include <type_traits>

chrono is NOT allowed since it is not freestanding

ask @SekaiArendelle

@trcrsired
Copy link
Member

trcrsired commented Jan 8, 2026

btw, you cannot assume you can use threads in newlib. newlib simply does NOT provide threads. The compiler will make weird decisions.

@MacroModel
Copy link
Collaborator Author

MacroModel commented Jan 8, 2026

btw, you cannot assume you can use threads in newlib. newlib simply does NOT provide threads. The compiler will make weird decisions.

no thread, only provided this_thread::sleep_for sleep_until and yield, the newlib provide a fake function there

@SekaiArendelle
Copy link

SekaiArendelle commented Jan 8, 2026

// std #include #include #include #include #include #include <type_traits>
chrono is NOT allowed since it is not freestanding

ask @SekaiArendelle

what can i say

@MacroModel
Copy link
Collaborator Author

MacroModel commented Jan 8, 2026 •
edited
Loading

// std #include #include #include #include #include #include <type_traits>
chrono is NOT allowed since it is not freestanding

ask @SekaiArendelle

what can i say

the solution is make them protected by macro __has_include

@MacroModel
Copy link
Collaborator Author

MacroModel commented Jan 10, 2026

@trcrsired add contidional include

@trcrsired
Copy link
Member

trcrsired commented Jan 10, 2026

为什么要在那些文件里加

#if __has_include()
#include
#endif

#include
#include
#include

完全就是瞎搞。而且谁规定你光has_include就能include了？禁止在全库所有的位置加include，懂？

@MacroModel
Copy link
Collaborator Author

MacroModel commented Jan 10, 2026

include

让 @SekaiArendelle 改了，这个他一开始就这么搞的

@MacroModel
Copy link
Collaborator Author

MacroModel commented Jan 10, 2026

你让他把这坨清理了

@SekaiArendelle
Copy link

SekaiArendelle commented Jan 10, 2026

你让他把这坨清理了

你让ai搞

@MacroModel
Copy link
Collaborator Author

MacroModel commented Jan 10, 2026

你让他把这坨清理了

你让ai搞

ok，等几天

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trcrsired trcrsired trcrsired left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MacroModel @trcrsired @SekaiArendelle