Alternate method of implementing wildcard support #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
@cppforlife any chances of getting wildcard support in? I'm wondering about how to resolve a few of the current ops-file shortcomings described in https://github.com/cloudfoundry/cf-deployment/blob/master/texts/issues-and-features-for-bosh.md#wildcard-paths-in-operations Even if the solution to this issue is not wildcard support, what's your view on how to overcome the current issues e.g. with an ops-file to rename the network in cf-deployment: https://github.com/cloudfoundry/cf-deployment/blob/master/operations/rename-network-and-deployment.yml |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cppforlife - here is an alternate way of implementing wildcard support.
The first commit restructures
replace_op.goto use a stack instead of a loop - while it touches a lot of lines, the changes to structure are minimal.The second adds wildcards.