Updated to not override images #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 17, 2015 11:46
Signed-off-by: Stefan Paychère <[email protected]>
Signed-off-by: Stefan Paychère <[email protected]>
- Only search for gravatar of entries without image (avoid overriding custom set images) - Only apply images for valid gravatars - handle async execution of URL requests Signed-off-by: Stefan Paychère <[email protected]>
Signed-off-by: Stefan Paychère <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've changed the behaviour to only look for Gravatars for contacts without image. This way, custom set images or previous runs are kept.
In the process, I updated to Swift 2.1, Xcode 7.1.1.
Also made the whole thing run asynchronously and wait for proper termination of URL requests.