nil dereferencing bug fixed #116
Conversation
|
@volodya-lombrozo please, check |
volodya-lombrozo
left a comment
volodya-lombrozo
left a comment
There was a problem hiding this comment.
@yegor256 Great thanks for the contribution! Just a single suggestion.
| } | ||
|
|
||
| func (a *Artifacts) Marshal() *protocol.MessageSendParams { | ||
| if a == nil { |
There was a problem hiding this comment.
@yegor256 I don't think we need to allow a nil receiver here. By doing this, we’re just hiding the original problem: 'Why do we have a nil here at all?'
There was a problem hiding this comment.
@volodya-lombrozo I have no idea, to be honest...
There was a problem hiding this comment.
@volodya-lombrozo I can try, but the bug may not be fixed in this case
There was a problem hiding this comment.
@yegor256 Maybe you can try it locally?
go install
refrax ...
There was a problem hiding this comment.
@volodya-lombrozo tests fail if I remove this check for nil. I can simply drop this PR, but I don't know how to fix the bug otherwise (since this PR is made by Claude Code, not me)
There was a problem hiding this comment.
@yegor256 I suggest closing it. I've successfully reproduced the issue. Thus, I can fix the bug properly
2 participants
fixes #115