Skip to content

style(#113): remove meaningless package comments #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
volodya-lombrozo merged 1 commit into from
Sep 18, 2025
Merged

style(#113): remove meaningless package comments #117

volodya-lombrozo merged 1 commit into from
Sep 18, 2025

Conversation

@volodya-lombrozo
Copy link
Collaborator

@volodya-lombrozo volodya-lombrozo commented Sep 17, 2025 •
edited
Loading

This PR remove meaningless package comments.

Also, I fixed a few 'panic' messages:

		case "message/stream":
			panic("message/stream is not implemented yet")
		case "tasks/get":
			panic("tasks/get is not implemented yet")
		case "tasks/cancel":
			panic("tasks/get is not implemented yet")

The message/stream is an id, not arbitrary text.

Related to #113

@volodya-lombrozo
Copy link
Collaborator Author

volodya-lombrozo commented Sep 17, 2025

@yegor256 could you review this one, please?

@yegor256
Copy link
Member

yegor256 commented Sep 17, 2025

@volodya-lombrozo LGTM

@volodya-lombrozo volodya-lombrozo merged commit 9eaf13c into cqfn:master Sep 18, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yegor256 yegor256 yegor256 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@volodya-lombrozo @yegor256