new test for params.go #139

yegor256 · 2025-12-13T05:22:40Z

related to #138

Copilot

Pull request overview

This PR adds comprehensive unit tests for the params.go file and the mask utility function, addressing issue #138. The tests validate the correct initialization of mock parameters and ensure the token masking functionality works as expected.

Key changes:

Added 16 tests for the NewMockParams() function covering most configuration fields
Added 4 tests for the mask() utility function covering basic masking scenarios

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

internal/client/params_test.go

Copilot · 2025-12-13T05:25:10Z

internal/client/params_test.go

+func TestMask_ReturnsEmptyForEmptyToken(t *testing.T) {
+	result := mask("")
+	assert.Equal(t, "", result, "mask of empty string must be empty")
+}
+
+func TestMask_MasksShortToken(t *testing.T) {
+	result := mask("AB")
+	assert.Equal(t, "AB", result, "short token must show visible part")
+}
+
+func TestMask_MasksLongToken(t *testing.T) {
+	result := mask("ABCDEFGH")
+	assert.Equal(t, "ABC*****", result, "long token must be masked")
+}
+
+func TestMask_ShowsThreeCharacters(t *testing.T) {
+	result := mask("secrettoken12345")
+	assert.NotEmpty(t, result, "masked token must not be empty")
+	assert.Equal(t, "sec*************", result, "token must show first three characters")
+}


The mask function being tested is located in refrax_client.go, not params.go. Consider moving these tests to refrax_client_test.go or renaming this test file to better reflect that it tests multiple components from the client package, not just params.go.

Copilot · 2025-12-13T05:25:11Z

internal/client/params_test.go

+func TestNewMockParams_CreatesValidInstance(t *testing.T) {
+	params := NewMockParams()
+	require.NotNil(t, params, "params must not be nil")
+}
+
+func TestNewMockParams_SetsMockProvider(t *testing.T) {
+	params := NewMockParams()
+	assert.Equal(t, "mock", params.Provider, "provider must be mock")
+}
+
+func TestNewMockParams_SetsDefaultToken(t *testing.T) {
+	params := NewMockParams()
+	assert.Equal(t, "ABC", params.Token, "token must be ABC")
+}
+
+func TestNewMockParams_EnablesMockProject(t *testing.T) {
+	params := NewMockParams()
+	assert.True(t, params.MockProject, "mock project must be enabled")
+}
+
+func TestNewMockParams_DisablesDebug(t *testing.T) {
+	params := NewMockParams()
+	assert.False(t, params.Debug, "debug must be disabled")
+}
+
+func TestNewMockParams_DisablesStats(t *testing.T) {
+	params := NewMockParams()
+	assert.False(t, params.Stats, "stats must be disabled")
+}
+
+func TestNewMockParams_SetsStdFormat(t *testing.T) {
+	params := NewMockParams()
+	assert.Equal(t, "std", params.Format, "format must be std")
+}
+
+func TestNewMockParams_SetsDefaultMaxSize(t *testing.T) {
+	params := NewMockParams()
+	assert.Equal(t, 200, params.MaxSize, "max size must be 200")
+}
+
+func TestNewMockParams_SetsDiscardLog(t *testing.T) {
+	params := NewMockParams()
+	assert.Equal(t, io.Discard, params.Log, "log must be io.Discard")
+}
+
+func TestNewMockParams_SetsDefaultChecks(t *testing.T) {
+	params := NewMockParams()
+	require.Equal(t, 1, len(params.Checks), "must have one check")
+	assert.Equal(t, "mvn clean test", params.Checks[0], "check must be mvn clean test")
+}
+
+func TestNewMockParams_DisablesColorless(t *testing.T) {
+	params := NewMockParams()
+	assert.False(t, params.Colorless, "colorless must be disabled")
+}
+
+func TestNewMockParams_SetsDefaultModel(t *testing.T) {
+	params := NewMockParams()
+	assert.Equal(t, "gpt-3.5-turbo", params.Model, "model must be gpt-3.5-turbo")
+}
+
+func TestNewMockParams_SetsDefaultAttempts(t *testing.T) {
+	params := NewMockParams()
+	assert.Equal(t, 3, params.Attempts, "attempts must be 3")
+}


The tests for NewMockParams do not cover all fields set by the function. Missing test coverage for: Playbook (should be empty string), Soutput (should be "stats"), Input (should be empty string), and Output (should be empty string). Consider adding tests for these fields to ensure complete coverage.

@copilot open a new pull request to apply changes based on this feedback

Copilot · 2025-12-13T05:25:11Z

internal/client/params_test.go

+func TestMask_ReturnsEmptyForEmptyToken(t *testing.T) {
+	result := mask("")
+	assert.Equal(t, "", result, "mask of empty string must be empty")
+}
+
+func TestMask_MasksShortToken(t *testing.T) {
+	result := mask("AB")
+	assert.Equal(t, "AB", result, "short token must show visible part")
+}
+
+func TestMask_MasksLongToken(t *testing.T) {
+	result := mask("ABCDEFGH")
+	assert.Equal(t, "ABC*****", result, "long token must be masked")
+}
+
+func TestMask_ShowsThreeCharacters(t *testing.T) {
+	result := mask("secrettoken12345")
+	assert.NotEmpty(t, result, "masked token must not be empty")
+	assert.Equal(t, "sec*************", result, "token must show first three characters")
+}


The mask function tests are missing important edge cases. Consider adding tests for: a single-character token (length 1), a three-character token (length 3, the boundary where visible equals token length), and a four-character token (length 4, the first case where masking occurs with one asterisk).

@copilot open a new pull request to apply changes based on this feedback

Co-authored-by: Copilot <[email protected]>

Copilot · 2025-12-13T05:26:12Z

@yegor256 I've opened a new pull request, #140, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2025-12-13T05:26:21Z

@yegor256 I've opened a new pull request, #141, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: yegor256 <[email protected]>

Add missing test coverage for NewMockParams fields

Add edge case tests for mask function boundary conditions

yegor256 · 2025-12-13T05:35:29Z

@volodya-lombrozo FYI

volodya-lombrozo · 2025-12-15T08:15:55Z

internal/client/params_test.go

+	assert.Equal(t, "", params.Output, "output must be empty")
+}
+
+func TestMask_ReturnsEmptyForEmptyToken(t *testing.T) {


@yegor256 All the TestMask are irrelevant to the params.go. Moreover, the mask function (refrax_client.go) is a private one, thus there is no need to test it separately.

@copilot fix the problem just mentioned

volodya-lombrozo · 2025-12-15T08:17:49Z

internal/client/params_test.go

+}
+
+func TestNewMockParams_DisablesStats(t *testing.T) {
+	params := NewMockParams()


@yegor256 Redundant variable?
https://www.yegor256.com/2015/09/01/redundant-variables-are-evil.html

@copilot fix this problem, get rid of the redundant variable

Copilot · 2025-12-15T09:15:28Z

@yegor256 I've opened a new pull request, #142, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2025-12-15T09:16:50Z

@yegor256 I've opened a new pull request, #143, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: yegor256 <[email protected]>

Remove private function tests from params_test.go

Remove redundant variable in TestNewMockParams_DisablesStats

yegor256 · 2025-12-15T13:20:56Z

@volodya-lombrozo fixed, please review again

test

cc5d89a

Copilot AI review requested due to automatic review settings December 13, 2025 05:22

Copilot started reviewing on behalf of yegor256 December 13, 2025 05:23 View session

Copilot AI reviewed Dec 13, 2025

View reviewed changes

yegor256 and others added 2 commits December 13, 2025 08:25

Update internal/client/params_test.go

64d38dd

Co-authored-by: Copilot <[email protected]>

Initial plan

f9acb0d

Copilot AI mentioned this pull request Dec 13, 2025

Add edge case tests for mask function boundary conditions #140

Merged

Initial plan

0e20e9d

Copilot AI mentioned this pull request Dec 13, 2025

Add missing test coverage for NewMockParams fields #141

Merged

Copilot AI and others added 4 commits December 13, 2025 05:28

Add edge case tests for mask function

2afe13d

Co-authored-by: yegor256 <[email protected]>

Add missing test coverage for NewMockParams fields

48601be

Co-authored-by: yegor256 <[email protected]>

Merge pull request #141 from cqfn/copilot/sub-pr-139-again

fc11dd6

Add missing test coverage for NewMockParams fields

Merge pull request #140 from cqfn/copilot/sub-pr-139

4b9f911

Add edge case tests for mask function boundary conditions

yegor256 requested a review from volodya-lombrozo December 13, 2025 05:35

volodya-lombrozo requested changes Dec 15, 2025

View reviewed changes

Initial plan

0859fd2

Copilot AI mentioned this pull request Dec 15, 2025

Remove private function tests from params_test.go #142

Merged

Initial plan

10ff813

Copilot AI mentioned this pull request Dec 15, 2025

Remove redundant variable in TestNewMockParams_DisablesStats #143

Merged

Copilot AI and others added 4 commits December 15, 2025 09:19

Remove redundant variable in TestNewMockParams_DisablesStats

85aef9f

Co-authored-by: yegor256 <[email protected]>

Remove TestMask tests from params_test.go

1b914c8

Co-authored-by: yegor256 <[email protected]>

Merge pull request #142 from cqfn/copilot/sub-pr-139-another-one

1e628a1

Remove private function tests from params_test.go

Merge pull request #143 from cqfn/copilot/sub-pr-139-yet-again

9a682e0

Remove redundant variable in TestNewMockParams_DisablesStats

volodya-lombrozo approved these changes Dec 15, 2025

View reviewed changes

volodya-lombrozo merged commit 5893bd2 into master Dec 15, 2025
6 checks passed

new test for params.go #139

new test for params.go #139

Uh oh!

Conversation

yegor256 commented Dec 13, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI Dec 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 13, 2025

Choose a reason for hiding this comment

Uh oh!

yegor256 Dec 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 13, 2025

Choose a reason for hiding this comment

Uh oh!

yegor256 Dec 13, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Dec 13, 2025

Uh oh!

Copilot AI commented Dec 13, 2025

Uh oh!

yegor256 commented Dec 13, 2025

Uh oh!

volodya-lombrozo Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

yegor256 Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

volodya-lombrozo Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

yegor256 Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Dec 15, 2025

Uh oh!

Copilot AI commented Dec 15, 2025

Uh oh!

yegor256 commented Dec 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants