Skip to content

Remove redundant variable in TestNewMockParams_DisablesStats #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yegor256 merged 2 commits into from
Dec 15, 2025
Merged

Remove redundant variable in TestNewMockParams_DisablesStats #143

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10ff813
Initial plan
Copilot Dec 15, 2025
85aef9f
Remove redundant variable in TestNewMockParams_DisablesStats
Copilot Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions internal/client/params_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,7 @@ func TestNewMockParams_DisablesDebug(t *testing.T) {
}

func TestNewMockParams_DisablesStats(t *testing.T) {
params := NewMockParams()
assert.False(t, params.Stats, "stats must be disabled")
assert.False(t, NewMockParams().Stats, "stats must be disabled")
Copy link

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This inline style is inconsistent with all other test functions in this file (lines 11-94), which store the result of NewMockParams() in a params variable before making assertions. For consistency and maintainability, consider either keeping the original two-line pattern or updating all similar test functions to use the inline style.

Suggested change
assert.False(t, NewMockParams().Stats, "stats must be disabled")
params := NewMockParams()
assert.False(t, params.Stats, "stats must be disabled")

Copilot uses AI. Check for mistakes.
}

func TestNewMockParams_SetsStdFormat(t *testing.T) {
Expand Down