Skip to content

Read milliseconds correctly from time and date time literals#1701

Draft
antvaset wants to merge 7 commits intomainfrom
milliseconds-in-literals
Draft

Read milliseconds correctly from time and date time literals#1701
antvaset wants to merge 7 commits intomainfrom
milliseconds-in-literals

Conversation

@antvaset
Copy link
Copy Markdown
Contributor

@antvaset antvaset commented Mar 12, 2026

Closes #1702.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 12, 2026

Related Issues

The following open issues may be related to this PR:

Issue Title Score Matched Terms
#886 ToString() does not return timezone extension 5.5 "date time", time (path), org (path), cql (path), date (path), test (path)
#734 Width allows Interval as a parameter 5.5 "date time", time (path), org (path), cql (path), tests (path), date (path)
#880 Additional test cases for date/time arithmetic 5 "date time", time (path), cql (path), date (path), test (path)
#1430 Correctly support CQL to FHIR (and vice versa) type mapping 5 correctly, resources (path), cqframework (path), java (path), src (path), time (path), main (path), org (path), cql (path)
#1700 Loading libraries from intermediary forms 4.5 cqframework (path), java (path), src (path), time (path), cql2elm (path), kotlin (path), main (path), org (path), cql (path)

Tip: If this PR addresses any of these issues, please link them using Closes #NNN or Refs #NNN in the PR description.

@github-actions
Copy link
Copy Markdown

Formatting check succeeded!

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.97%. Comparing base (a21ac0b) to head (9438ed1).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1701   +/-   ##
=========================================
  Coverage     61.97%   61.97%           
  Complexity     3940     3940           
=========================================
  Files           210      210           
  Lines         20366    20366           
  Branches       3879     3879           
=========================================
  Hits          12621    12621           
  Misses         6138     6138           
  Partials       1607     1607           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

define DateTimeMillisecond1Literal: @2014-02-12T10:30:15.1
define DateTimeMillisecond12Literal: @2014-02-12T10:30:15.12
define DateTimeMillisecond123Literal: @2014-02-12T10:30:15.123
define DateTimeMillisecond1234Literal: @2014-02-12T10:30:15.1234
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is "1234" rounded down to "123? If so, I think you should test "1238" with a clear expectation of whether "123" or "124" should be resolved.

Copy link
Copy Markdown
Contributor

@JPercival JPercival Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.123 seconds, or 123 milliseconds.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just doublechecked the spec, constrained to 1...999

@JPercival JPercival enabled auto-merge (squash) March 12, 2026 21:38
@JPercival JPercival disabled auto-merge March 12, 2026 21:39
@antvaset
Copy link
Copy Markdown
Contributor Author

In draft until cqframework/cql-tests#99 is resolved.

@antvaset antvaset marked this pull request as draft March 13, 2026 22:35
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Milliseconds are read incorrectly from time and date time literals

3 participants