Read milliseconds correctly from time and date time literals#1701
Read milliseconds correctly from time and date time literals#1701
Conversation
Related IssuesThe following open issues may be related to this PR:
|
|
Formatting check succeeded! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1701 +/- ##
=========================================
Coverage 61.97% 61.97%
Complexity 3940 3940
=========================================
Files 210 210
Lines 20366 20366
Branches 3879 3879
=========================================
Hits 12621 12621
Misses 6138 6138
Partials 1607 1607 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| define DateTimeMillisecond1Literal: @2014-02-12T10:30:15.1 | ||
| define DateTimeMillisecond12Literal: @2014-02-12T10:30:15.12 | ||
| define DateTimeMillisecond123Literal: @2014-02-12T10:30:15.123 | ||
| define DateTimeMillisecond1234Literal: @2014-02-12T10:30:15.1234 |
There was a problem hiding this comment.
Is "1234" rounded down to "123? If so, I think you should test "1238" with a clear expectation of whether "123" or "124" should be resolved.
There was a problem hiding this comment.
.123 seconds, or 123 milliseconds.
There was a problem hiding this comment.
Just doublechecked the spec, constrained to 1...999
|
In draft until cqframework/cql-tests#99 is resolved. |
|


Closes #1702.