Skip to content

Change nsi template from using association.ext to association.extensions, to match struct field in FileAssociation.#365

Merged
FabianLars-crabnebula merged 3 commits intocrabnebula-dev:mainfrom
mountainlizard:fix-nsis-file-associations
Aug 12, 2025
Merged

Change nsi template from using association.ext to association.extensions, to match struct field in FileAssociation.#365
FabianLars-crabnebula merged 3 commits intocrabnebula-dev:mainfrom
mountainlizard:fix-nsis-file-associations

Conversation

@trepidacious
Copy link
Copy Markdown
Contributor

This allows file associations to be generated in .nsi files, and therefore in the final NSIS installer.

Fixes #364

@FabianLars-crabnebula
Copy link
Copy Markdown
Contributor

Thanks for the PR! I know the change is fairly small but i need all commits of a PR signed to be able to merge it (i don't have admin permissions like Lucas in your last PR to overwrite that here, not that i'd want to). Also, a small changefile similar to https://github.com/mountainlizard/cargo-packager/blob/52b12e3aad2805af79c49a5ea3133280a1576e83/.changes/notarize-keychain.md would be appreciated.

Thanks again :)

…nsions`, to match struct field in `FileAssociation`.

This allows file associations to be generated in `.nsi` files, and therefore in the final NSIS installer.
@trepidacious trepidacious force-pushed the fix-nsis-file-associations branch from ab31e71 to dcc2ac7 Compare August 11, 2025 19:48
@trepidacious
Copy link
Copy Markdown
Contributor Author

trepidacious commented Aug 11, 2025

You're very welcome, thanks for the pointers - I've amended the original commit to be signed, and added a change file as requested.
Quick query on the notarize-keychain.md file, would it technically be a minor change rather than a patch, since it introduces a new (backwards compatible) feature?

@FabianLars-crabnebula
Copy link
Copy Markdown
Contributor

yes, in my eyes a minor would have been more appropriate since the public api was affected

@FabianLars-crabnebula FabianLars-crabnebula merged commit c34de36 into crabnebula-dev:main Aug 12, 2025
18 of 19 checks passed
@denjell-crabnebula
Copy link
Copy Markdown
Contributor

Thankyou @trepidacious

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NSIS installer does not include file associations

3 participants