packager: codesign: macos: Fix certificates#376
Merged
FabianLars-crabnebula merged 2 commits intocrabnebula-dev:mainfrom Sep 24, 2025
Merged
packager: codesign: macos: Fix certificates#376FabianLars-crabnebula merged 2 commits intocrabnebula-dev:mainfrom
FabianLars-crabnebula merged 2 commits intocrabnebula-dev:mainfrom
Conversation
Contributor
|
Thanks for the PR! would you mind adding a changefile like https://github.com/crabnebula-dev/cargo-packager/blob/main/.changes/deb-package-name.md so we can release this? :) |
Currently, it is not possible to pass signing_certificate and signing_certificate_password using Cargo.toml of config json. Instead, from what I gather, environment variables should be used for these variables. However, the current logic to fallback to environment variables is erroneous and will only use environment variables if no macos property is defined, as opposed to if the variable is not found in the config. Signed-off-by: Ayush Singh <ayush@beagleboard.org>
Create changefile for the fixes. Signed-off-by: Ayush Singh <ayush@beagleboard.org>
Ayush1325
force-pushed
the
test-branch
branch
from
c1fbb4a to
49f6dac
Compare
FabianLars-crabnebula
approved these changes
Sep 24, 2025
FabianLars-crabnebula
merged commit b2b4916
into
crabnebula-dev:main
21 of 22 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, it is not possible to pass signing_certificate and signing_certificate_password using Cargo.toml of config json. Instead, from what I gather, environment variables should be used for these variables. However, the current logic to fallback to environment variables is erroneous and will only use environment variables if no macos property is defined, as opposed to if the variable is not found in the config.