Merged
Conversation
✅ Deploy Preview for cn-devtools-app ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Author
|
I found there was a disconnect between our CSP header implementation and the actual deployment, so I fixed it. The deployment was also broken by the sentry-netlify plugin that is solely used to upload the source maps to sentry for each release, so I removed it for now. |
alex-crabnebula
force-pushed
the
fix/csp-settings
branch
3 times, most recently
from
a43c5e1 to
8f5eb27
Compare
alex-crabnebula
force-pushed
the
fix/csp-settings
branch
from
8f5eb27 to
d924ea7
Compare
alex-crabnebula
requested review from
adam-crabnebula and
beanow-at-crabnebula
and removed request for
adam-crabnebula
beanow-at-crabnebula
approved these changes
Jun 17, 2025
Member
beanow-at-crabnebula
left a comment
beanow-at-crabnebula
left a comment
There was a problem hiding this comment.
Only able to do limited tests, as the deployment preview URL isn't an allowed CORS origin by the devtools tauri plugin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #366; we are not getting around inline styles, as both
@tanstack/solid-virtual(all virtualized scrolling lists) and@kobalte/core(tooltips) require them; includes CSP settings to allow for fathom. Some of the other settings seem to have been previously fixed, but never deployed.