fix(gui): explicitly set GLSL profile in shaders#227
Merged
craftablescience merged 1 commit intocraftablescience:mainfrom Mar 16, 2025
Exotic0015:main
Merged
fix(gui): explicitly set GLSL profile in shaders#227craftablescience merged 1 commit intocraftablescience:mainfrom Exotic0015:main
craftablescience merged 1 commit intocraftablescience:mainfrom
Exotic0015:main
Conversation
Owner
|
awesome, thanks! I don't have an nvidia gpu on any of my machines, so didn't even know this was a bug |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason, current Nvidia drivers on Linux don't set a default OpenGL profile:
While other vendors do, an example from an AMD gpu:
This causes shaders used in model previews to fail compilation, making them not render with the logs containing the following lines, among others:
This PR works around this issue specifying the used GLSL profile in the shader sources. This is fully spec compliant, as can be seen here.