Skip to content

Add an allVariants setter to Product element #4200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
lukeholder wants to merge 2 commits into
base: 5.x
Choose a base branch
from
+12 −0
Draft

Add an allVariants setter to Product element #4200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90aecae
WIP fix
lukeholder Jan 14, 2026
2e8b0f7
Merge branch '5.x' into luke/4199
lukeholder Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## Unreleased

- Fixed a bug where merging canonical changes into a product draft could fail if variant changes existed. ([#4199](https://github.com/craftcms/commerce/issues/4199))
- Fixed a bug where the order’s table was showing the incorrect column heading on the Edit User page.
- Fixed two high-severity SQL injection vulnerabilities in the control panel. (GHSA-j3x5-mghf-xvfw, GHSA-pmgj-gmm4-jh6j)

Expand Down
11 changes: 11 additions & 0 deletions src/elements/Product.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1216,6 +1216,17 @@ public function getAllVariants(): VariantCollection
return $this->getVariants(true);
}

/**
* @param VariantCollection|VariantQuery|array $variants
* @return void
* @throws InvalidConfigException
* @internal Do not use. Temporary method until we get a nested element manager provider in core.
*/
public function setAllVariants(VariantCollection|VariantQuery|array $variants): void
{
$this->setVariants($variants);
}

/**
* @inheritdoc
*/
Expand Down
Loading