only call EVENT_BEFORE_PROCESS_FEED once per page, as before#1628
Merged
only call EVENT_BEFORE_PROCESS_FEED once per page, as before#1628
EVENT_BEFORE_PROCESS_FEED once per page, as before#1628Conversation
Contributor
|
I am looking forward to this PR being merged! |
angrybrad
deleted the
bugfix/1619-batched-job-and-before-process-feed-event
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug where
EVENT_BEFORE_PROCESS_FEEDwas called once per batch and not once per page as intended and as it was before we introduced theBaseBatchedJobto Feed Me.Process::EVENT_BEFORE_PROCESS_FEEDis called once per page (if there’s no pagination, then there’s one page, so it’s called once) - that was also the case before we implementedBaseBatchedJobProcess::EVENT_AFTER_PROCESS_FEEDis called once for the entire import (regardless of pagination)Process::EVENT_STEP_BEFORE_PARSE_CONTENTis called for every primary element that was found in the feed’s dataDataTypes::EVENT_BEFORE_FETCH_FEED,DataTypes::EVENT_AFTER_FETCH_FEED,DataTypes::EVENT_AFTER_PARSE_FEEDare called whenever feed data needs to be retrieved, which means as minimum once per batchRelated issues
#1619