respect folder when replacing existing asset #1705
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When importing into an Assets field with “Create asset from URL” and conflict resolution method is set to “Replace existing asset” or “Keep both (rename feed data)”, if an existing asset matching the criteria is found, respect its folder ID instead of creating a new asset in the default upload location folder of the field. The same way the folder is respected when conflict resolution is set to “Use existing asset”.
Note that when searching for existing elements, the default upload location is taken into consideration. This means that if the default upload location is a subfolder and an existing asset is in the root folder of the volume, that existing asset won’t be found in the first place (meaning there’s no folder to respect).
Related issues
#1704