Fix ValidationError on BooleanField with None value#27
Merged
Conversation
BooleanField.to_python(None) raises ValidationError. Skip fields that raise ValidationError during change detection, treating them like deferred fields. This prevents crashes during admin instantiation of models with non-nullable BooleanFields. Fixes #13
There was a problem hiding this comment.
Pull request overview
This PR fixes a crash that occurs when Django models with non-nullable BooleanFields are instantiated with None values, which commonly happens in Django admin forms before user input. The fix wraps the field.to_python() call in a try-except block to gracefully handle ValidationError exceptions by skipping invalid fields during change detection.
- Adds exception handling for
ValidationErrorin field change detection - Implements tests for BooleanField with None values
- Ensures invalid fields are skipped similar to deferred fields
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| fieldsignals/signals.py | Adds try-except block around field.to_python() to catch ValidationError and skip fields with invalid values, preventing crashes during change detection |
| fieldsignals/tests/test_signals.py | Adds BooleanField test class and two test cases: one verifying that post_init doesn't crash with None values, and another testing field transitions from invalid to valid states |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13
Summary
Details
When models with non-nullable BooleanField are instantiated with None values (as Django admin does),
field.to_python()raises ValidationError. This wraps the call in try-except to skip invalid fields during change detection, similar to how deferred fields are handled.Test Plan
Created with Claude Code