Skip virtual fields like GenericForeignKey#28
Merged
Conversation
Virtual fields (concrete=False) like GenericForeignKey don't have database columns, causing AttributeError when accessing field.attname. Skip them like reverse relations are skipped. Fixes #16
562107a to
9cdea08
Compare
There was a problem hiding this comment.
Pull request overview
This PR fixes an AttributeError that occurs when Django models contain GenericForeignKey or other virtual fields (fields with concrete=False). Virtual fields don't have database columns and lack the attname attribute, causing crashes when the library attempts to track field changes. The fix filters out virtual fields automatically and raises a clear error when they're explicitly requested.
- Adds
is_virtual_field()helper to identify virtual fields by checking theconcreteattribute - Filters out virtual fields during auto-detection (similar to existing reverse relation filtering)
- Adds runtime check to skip virtual fields in
get_and_update_changed_fields() - Provides clear error messages when virtual fields are explicitly requested
- Adds comprehensive test coverage for virtual field handling
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| fieldsignals/signals.py | Implements virtual field detection and filtering logic to prevent AttributeError when accessing field.attname on GenericForeignKey and similar virtual fields |
| fieldsignals/tests/test_signals.py | Adds VirtualField mock class, FakeModelWithVirtualField test model, and test cases to verify virtual fields are auto-excluded and raise clear errors when explicitly requested |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix AttributeError when models have GenericForeignKey fields.
Virtual fields (concrete=False) like GenericForeignKey don't have database columns, causing AttributeError when accessing field.attname. This PR skips them like reverse relations are skipped.
Fixes #16