Add ROM PAR mapping quirk to the MMU#121
Merged
craigthomas merged 4 commits intomainfrom Feb 20, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #121 +/- ##
============================================
- Coverage 54.90% 54.24% -0.67%
- Complexity 966 996 +30
============================================
Files 64 63 -1
Lines 4340 4515 +175
Branches 494 527 +33
============================================
+ Hits 2383 2449 +66
- Misses 1877 1982 +105
- Partials 80 84 +4 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a ROM mapping quirk to the MMU. With ROM pages
$3Cto$3F, the mapping of the page to a task or executive PAR contains a quirk - the page requested uses the upper 6 bits from the page specified, but the bottom 2 bits from the slot that it is mapped into. This means that if page$3Dis mapped to slot 2, the effective page mapped to slot 2 is$3E. Unit tests added to catch new conditions.