-
Notifications
You must be signed in to change notification settings - Fork 878
Add support for Arduino ESP32 core v3.x - IDF v5.x #2215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Arduino ESP32 core v3.x - IDF v5.x #2215
Conversation
Doxygen docs update for v2.8.7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove changes of version and doc updates from git history and force push, those changes are only done in the release process.
2 fails now |
Don't close PRs, fix the commits and force-push. |
Sorry I mistakenly took a link supplied by one of your collogues too literal and didn't see it was just for reference. I obviously broke something in my attempt to fix as you requested and nothing would update. Won't bother you ever again but if you're interested I've published the patch I made that adds ESP32 Arduino Core V3.x functionality to IRremoteESP8266 (v2.8.6) here |
This PR patches the IRremoteESP8266 library for compatibility with the updated Arduino ESP32 Core v3.x timer API which will address the feature request #2039
Key changes:
timerBegin()
/timerAlarmEnable()
usage with new APIlibrary.properties
to reflect version2.8.7
Notes:
This PR is intended to maintain backward compatibility while ensuring ESP32 users can continue using the library after upgrading the core. The fork will remain maintained until upstream merges this patch.
Hardware Testing
IRrecvDumpV2.ino
example I compiled and uploaded to a ESP-WROOM-32 based dev with a TSOP4136 attached and tested IR capture. Proved working by multiple captures of the same button. Works well and no issues found.IRrecvDumpV2.ino
with both Arduino IDE v1.8.19 and the current v2.3.6 using both Arduino ESP32 core v2.0.17 and current v3.3.0. No errors or warning.Compile Checks
IRrecvDumpV2.ino
compiled selecting the genericESP8266
to confirm nothing broken. No errors reported.ESP32S3
. No errors but two (2) benign warnings not related to the IRremoteESP8266 library.ESP8266
. No errors and one JSON warning that should disappear when ArduinoJson V8.x is released.A long overdue patch, hopefully this PR meets with your approval
— macca-nz / macca448