Skip to content

Conversation

macca448
Copy link

This PR patches the IRremoteESP8266 library for compatibility with the updated Arduino ESP32 Core v3.x timer API which will address the feature request #2039

Key changes:

  • Added V3x timerBegin() / timerAlarmEnable() usage with new API
  • Confirmed working on latest ESP32 Core (3.x) using Arduino IDE
  • Rolled back and confirmed still working on ESP32 Core (2.x) using Arduino IDE
  • Updated library.properties to reflect version 2.8.7
  • Maintains full functionality from v2.8.6

Notes:

This PR is intended to maintain backward compatibility while ensuring ESP32 users can continue using the library after upgrading the core. The fork will remain maintained until upstream merges this patch.

Hardware Testing

  • Using IRrecvDumpV2.ino example I compiled and uploaded to a ESP-WROOM-32 based dev with a TSOP4136 attached and tested IR capture. Proved working by multiple captures of the same button. Works well and no issues found.
  • Tried IRrecvDumpV2.ino with both Arduino IDE v1.8.19 and the current v2.3.6 using both Arduino ESP32 core v2.0.17 and current v3.3.0. No errors or warning.
  • Updated my ESP32 IR-Blaster project with this sketch and all 3 protocols (RCMM, NEC & PANASONIC) are working with no errors.

Compile Checks

  • Using IRrecvDumpV2.ino compiled selecting the generic ESP8266 to confirm nothing broken. No errors reported.
  • Using this sketch from my IR-Blaster project I selected ESP32S3. No errors but two (2) benign warnings not related to the IRremoteESP8266 library.
  • Using this sketch from my IR-Blaster project I selected Generic ESP8266. No errors and one JSON warning that should disappear when ArduinoJson V8.x is released.

A long overdue patch, hopefully this PR meets with your approval

— macca-nz / macca448

macca448 added 5 commits July 31, 2025 13:35
v2.8.7 Release to adds support for Arduino ESP32 core V3.x - IDF v5.x
Doxygen docs update for v2.8.7
v2.8.7 Release to adds support for Arduino ESP32 core V3.x - IDF v5.x
v2.8.7 Release to adds support for Arduino ESP32 core V3.x - IDF v5.x
@NiKiZe
Copy link
Collaborator

NiKiZe commented Jul 31, 2025

Again, do not modify documentation or version numbers, that is done as part of the release process.

This seems to be duplicate of #2144 and #2040, how is this better than any of those?

Use git rebase -i and remove irrelevant commits, and then force push clean changes.

Copy link
Collaborator

@NiKiZe NiKiZe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove changes of version and doc updates from git history and force push, those changes are only done in the release process.

@macca448
Copy link
Author

2 fails now

@macca448 macca448 closed this Jul 31, 2025
@NiKiZe
Copy link
Collaborator

NiKiZe commented Jul 31, 2025

Don't close PRs, fix the commits and force-push.
And again, this seems like a duplicate of #2039

@macca448
Copy link
Author

macca448 commented Aug 1, 2025

Sorry I mistakenly took a link supplied by one of your collogues too literal and didn't see it was just for reference.

I obviously broke something in my attempt to fix as you requested and nothing would update.

Won't bother you ever again but if you're interested I've published the patch I made that adds ESP32 Arduino Core V3.x functionality to IRremoteESP8266 (v2.8.6) here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants