fix: resolve bug in Complex demo#383
Closed
GEFNENEN wants to merge 2 commits intocrashkonijn:masterfrom
Closed
Conversation
Fixed a bug where the CreateItemAction consumed resources without producing items.
Move resource removal to Complete method
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the Complex demo where the CreateItemAction would consume resources (iron and wood) without producing the corresponding items. The fix ensures atomic behavior by moving resource removal to happen only when item creation completes successfully.
Changes:
- Moved
RemoveRequiredResourcescall fromBeforePerformtoCompletemethod to ensure resources are only consumed when items are successfully created
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
I've created another pull request to fix it correctly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a bug where the CreateItemAction consumed resources without producing items.