fix: resolve bug in Complex demo#384
Merged
crashkonijn merged 3 commits intocrashkonijn:masterfrom Jan 14, 2026
Merged
Conversation
Fixed a bug where the CreateItemAction consumed resources without producing items.
GEFNENEN
changed the title
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the Complex demo by preventing the CreateItemAction from being interrupted when its conditions change during execution. The action removes Iron and Wood resources from the inventory during execution, which would invalidate its own conditions without the fix.
Changes:
- Added
.SetValidateConditions(false)toCreateItemActionconfiguration to prevent mid-execution interruption - Fixed whitespace formatting at the end of two files
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Demo/Assets/CrashKonijn/GOAP/Demos/Complex/Factories/Extensions/ActionExtensions.cs | Added .SetValidateConditions(false) to prevent action interruption when resources are consumed; fixed trailing whitespace |
| Demo/Assets/CrashKonijn/GOAP/Demos/Complex/Actions/CreateItemAction.cs | Fixed trailing whitespace formatting |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
Great fix, thank you for your PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a bug where the CreateItemAction consumed resources without producing items.