Skip to content

wait until the last minute to load sounds #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

wait until the last minute to load sounds #118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
466f7c5
init audioContext at the last moment
aaron13100 Nov 28, 2023
f7c5ad2
wait until the last minute to initialize sounds
aaron13100 Nov 28, 2023
ef3f873
Update sound.ts
aaron13100 Nov 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/fireworks-js/src/fireworks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,7 @@ export class Fireworks {
}

private initTrace(): void {
this.sound.init();
if (this.waitStopRaf) return

const { delay, mouse } = this.opts
Expand Down
4 changes: 1 addition & 3 deletions packages/fireworks-js/src/sound.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ export class Sound {
private onInit = false

constructor(private readonly options: Options) {
this.init()
}

private get isEnabled() {
Expand Down Expand Up @@ -49,6 +48,7 @@ export class Sound {
}

play(): void {
this.init()
if (this.isEnabled && this.buffers.length) {
const bufferSource = this.audioContext.createBufferSource()
const soundBuffer = this.buffers[randomInt(0, this.buffers.length - 1)]!
Expand All @@ -62,8 +62,6 @@ export class Sound {
volume.connect(this.audioContext.destination)
bufferSource.connect(volume)
bufferSource.start(0)
} else {
this.init()
}
}
}