Skip to content

Replaced deprecated cargo --all flag with --workspace flag #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Replaced deprecated cargo --all flag with --workspace flag #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions azure/cargo-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,14 +29,12 @@ jobs:
- script: cargo check --locked
condition: and(succeeded(), eq(variables.is_locked, 'true'))
displayName: Check that Cargo.lock is satisfiable
- script: cargo check --all --bins --examples --tests
- script: cargo check --workspace --bins --examples --tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As djc mentioned, we support pinning to older Rust versions, particularly for MSRV validation. I think the simpler approach is for us to keep using --all until either they plan to remove it or until the Rust version is so old we don't care about supporting it still.

displayName: Check compilation w/ default features
- script: cargo check --all --bins --examples --tests --no-default-features
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about for crates where --all evaluates to one crate?

displayName: Check compilation w/ no features
- ${{ if eq('true', parameters.all_features) }}:
- script: cargo check --all --bins --examples --tests --all-features
- script: cargo check --workspace --bins --examples --tests --all-features
displayName: Check compilation w/ all features

- ${{ if ne('false', parameters.benches) }}:
- script: cargo check --benches --all
- script: cargo check --benches --workspace
displayName: Check benchmarks
2 changes: 1 addition & 1 deletion azure/cargo-clippy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,5 @@ jobs:
setup: ${{ parameters.setup }}
components:
- clippy
- script: cargo clippy --all
- script: cargo clippy --workspace
displayName: Run clippy
8 changes: 4 additions & 4 deletions azure/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,22 +43,22 @@ jobs:
env:
FEATURES: ${{ join(',', parameters.features) }}
- ${{ if ne('true', parameters.single_threaded) }}:
- script: cargo test --all $(features)
- script: cargo test --workspace $(features)
displayName: Run tests
env:
${{ insert }}: ${{ parameters.envs }}
- ${{ if eq('true', parameters.single_threaded) }}:
- script: cargo test --all $(features) -- --test-threads=1
- script: cargo test --workspace $(features) -- --test-threads=1
displayName: Run tests (single-threaded)
env:
${{ insert }}: ${{ parameters.envs }}
- ${{ if and(eq('true', parameters.test_ignored), ne('true', parameters.single_threaded)) }}:
- script: cargo test --all $(features) -- --ignored
- script: cargo test --workspace $(features) -- --ignored
displayName: Run ignored tests
env:
${{ insert }}: ${{ parameters.envs }}
- ${{ if and(eq('true', parameters.test_ignored), eq('true', parameters.single_threaded)) }}:
- script: cargo test --all $(features) -- --ignored --test-threads=1
- script: cargo test --workspace $(features) -- --ignored --test-threads=1
displayName: Run ignored tests (single-threaded)
env:
${{ insert }}: ${{ parameters.envs }}