Conversation
amotl
force-pushed
the
cratedb
branch
2 times, most recently
from
16d7f61 to
3526db7
Compare
kneth
reviewed
Apr 3, 2025
|
|
||
| # Test disconnect tool if available | ||
| break # Exit schema loop once we've found a table | ||
| # break # Exit schema loop once we've found a table |
Author
There was a problem hiding this comment.
It can be removed, sure. I didn't want to change too much compared to the original, that's why it's just a comment.
Author
There was a problem hiding this comment.
Please also note this PR is just for visibility purposes. It will probably never be merged, at least not in its current form.
amotl
force-pushed
the
cratedb
branch
3 times, most recently
from
4a8537a to
82733d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About
pg-mcp uses asyncpg, so it can also be used with CrateDB. A little walkthrough how to use it has been added to the README for CrateDB.
Details
server/resources/schema.pyneeded to receive a few adjustments to compensate for missing metadata features of CrateDB, nothing serious. @kneth: Maybe carry the gist of that diff forward to the CrateDB issue tracker in one way or another?