-
Notifications
You must be signed in to change notification settings - Fork 10
Documentation: Fix broken links to Doctrine ORM #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughDocumentation references across multiple files are updated from Doctrine version 3.0 to 3.6, including anchor links and external documentation URLs. A minor PHP syntax correction (missing comma) is applied in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Repository UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (5)
🧰 Additional context used🧠 Learnings (2)📚 Learning: 2025-11-21T18:32:35.719ZApplied to files:
📚 Learning: 2025-11-19T23:30:55.289ZApplied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
docs/connect.rst (1)
67-72: Fix the PHP syntax error in the array definition.Line 69 is missing a comma after
'user' => 'crate', which will cause a parse error.🔎 Proposed fix
$params = array( 'driverClass' => 'Crate\DBAL\Driver\PDOCrate\Driver', - 'user' => 'crate' + 'user' => 'crate', 'host' => 'localhost', 'port' => 4200 );
📜 Review details
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
docs/appendices/compatibility.rstdocs/appendices/data-types.rstdocs/build.jsondocs/connect.rstdocs/index.rst
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-11-21T18:32:35.719Z
Learnt from: amotl
Repo: crate/crate-dbal PR: 122
File: src/Crate/DBAL/Driver/PDOCrate/PDOConnection.php:0-0
Timestamp: 2025-11-21T18:32:35.719Z
Learning: Documentation update: docs/index.rst now explicitly states CrateDB implements eventual consistency and does not support traditional ACID transactions (commit 171116851). Preference in this repo is to document this limitation rather than raise runtime exceptions in transaction methods.
Applied to files:
docs/index.rstdocs/connect.rst
📚 Learning: 2025-11-19T23:30:55.289Z
Learnt from: amotl
Repo: crate/crate-dbal PR: 122
File: src/Crate/DBAL/Driver/PDOCrate/PDOConnection.php:48-48
Timestamp: 2025-11-19T23:30:55.289Z
Learning: In crate-dbal's PDOConnection.php, PDO::ATTR_STATEMENT_CLASS is set using a bare class string (PDOStatement::class) rather than the standard PDO array format ([ClassName::class, [args]]) because PDOCrateDB is a custom PDO implementation that accepts a class name string directly for this attribute.
Applied to files:
docs/index.rst
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Build docs on ubuntu-latest
🔇 Additional comments (5)
docs/build.json (1)
4-4: LGTM!The version bump from 2.1.2 to 2.2.0 is appropriate for documentation updates.
docs/appendices/compatibility.rst (1)
76-76: Documentation link is accessible and correctly updated.The URL for the Doctrine DBAL 3.6 query builder reference returns HTTP 200, confirming the link update from version 3.0 to 3.6 is valid and aligns with the PR's objective to fix broken documentation references.
docs/appendices/data-types.rst (1)
114-114: The updated Doctrine ORM documentation link is accessible and correctly configured.The link at line 114 (https://www.doctrine-project.org/projects/doctrine-orm/en/3.6/reference/basic-mapping.html) returns HTTP 200, confirming it is reachable. The version update from 3.0 to 3.6 is properly applied and aligns with the PR's objective to fix broken documentation references.
docs/connect.rst (1)
107-107: Documentation links are all accessible.All four updated documentation links (DBAL 3.6 and ORM 3.6) return HTTP 200 and are working correctly. The version updates from 3.0 to 3.6 align with the PR's objective to fix broken links.
docs/index.rst (1)
37-37: Documentation links are properly updated and accessible.Both the DBAL and Doctrine ORM documentation links have been successfully updated to version 3.6 and are accessible (HTTP 200). The changes align with the PR's objective to fix broken links.
Just maintenance.