Skip to content

Conversation

@mackerl
Copy link
Contributor

@mackerl mackerl commented Nov 21, 2025

  • handle child process exits
  • handle temporary file locks
  • different urls for windows and linux
  • upgrade cratedb tested version as 3.x is not released as zip
  • no latest test as there is no latest download link for windows
  • TODO: few fixes left, but don't know how at the moment
  • TODO: cannot upload large files in src/test/resources - locally I had there the 6.1.1 for windows and not windows

Summary of the changes / Why this is an improvement

Checklist

  • Link to issue this PR refers to (if applicable): Fixes #???

* handle child process exits
* handle temporary file locks
* different urls for windows and linux
* upgrade cratedb tested version as 3.x is not released as zip
* no latest test as there is no latest download link for windows
* TODO: few fixes left, but don't know how at the moment
@mackerl
Copy link
Contributor Author

mackerl commented Nov 21, 2025

I came quite far with supporting windows, altough its a pain :) (files access, child processes ...)
However now I face some limitations ... I cannot upload huge zips, tar.gz to fork in lfs mode as I am not the branch owner
I failed to fix some tests as I lack there knowledge whats happening in crate.

@amotl
Copy link
Member

amotl commented Nov 21, 2025

I came quite far with supporting windows, altough its a pain :) (files access, child processes ...)

Hi Mario. Thanks a stack for your contribution. I experienced similar pains like you when trying to manage the CrateDB process lifecycle on Windows the other day in Python lands at mfussenegger/cr8#337. 1

Footnotes

  1. In order not to hijack the discussion on this PR, I've elaborated about it in Support for testing on Windows #93, also to explore the problem domain beyond crate-java-testing, looking at potential solutions around using container technologies instead of manual process management.

@matriv
Copy link
Contributor

matriv commented Nov 25, 2025

Thx @mackerl I will take a look in the next days.

@matriv matriv self-assigned this Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants