Handle transient errors gracefully in health check#734
Merged
Conversation
8896615 to
0fdd343
Compare
plaharanne
reviewed
Apr 29, 2025
widmogrod
approved these changes
Apr 29, 2025
There was a problem hiding this comment.
LGTM.
- Checkout the code, test are running on mac
- Code coverage looks good with this functionality
I have a nitpick.
- This PR is shipping two changes - one is "black to support match-case syntax." and second is handling errors gracefully - I would suggest to split them in two PR or two commits. First appraoch allow to have more granular changes and simpler code review, since linter changes are deterministic, and they don't need to block more nuanced changes.
652105e to
a64b95e
Compare
a64b95e to
e0c8893
Compare
Contributor
Author
I created #735 for the upgrade of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
This improves the
ping_cratedb_statushandler by catching transient errors (like ClientConnectorError and TimeoutError) and logs them as warnings instead of raising unhandled exceptions.I also had to upgrade black to support match-case syntax.
Checklist
CHANGES.rst