Skip to content

Comments

Handle internal table restore and cleanup after snapshot restore finished#788

Merged
tomach merged 1 commit intomasterfrom
ta/fix-restore-all
Nov 13, 2025
Merged

Handle internal table restore and cleanup after snapshot restore finished#788
tomach merged 1 commit intomasterfrom
ta/fix-restore-all

Conversation

@tomach
Copy link
Contributor

@tomach tomach commented Nov 7, 2025

Summary of changes

Introduces RestoreInternalTablesSubHandler to handle GC table cleanup or rollback after restore has finished.
Adds shared _get_failed_dependent_handlers() helper for consistent dependency checks, removes redundant logic, and fixes GC table matching by stripping _temp suffix.

Checklist

  • Link to issue this PR refers to: https://github.com/crate/cloud/issues/2241
  • Relevant changes are reflected in CHANGES.rst
  • Added or changed code is covered by tests
  • Documentation has been updated if necessary
  • Changed code does not contain any breaking changes (or this is a major version change)

@tomach tomach force-pushed the ta/fix-restore-all branch from 88beee6 to eb88433 Compare November 10, 2025 13:02
@tomach tomach force-pushed the ta/fix-restore-all branch from eb88433 to a8d9cdd Compare November 12, 2025 09:27
@tomach tomach changed the title Handle internal table restore and cleanup after snapshot restore fini… Handle internal table restore and cleanup after snapshot restore finished Nov 12, 2025
@tomach tomach marked this pull request as ready for review November 12, 2025 10:21
Copy link
Contributor

@plaharanne plaharanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@tomach tomach merged commit 65a30ca into master Nov 13, 2025
15 checks passed
@tomach tomach deleted the ta/fix-restore-all branch November 13, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants