-
Notifications
You must be signed in to change notification settings - Fork 9
.NET/CI: Improve testing, also against pre-release versions of Npgsql #1257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughTwo GitHub Actions workflows were updated to add an Changes
Sequence Diagram(s)sequenceDiagram
participant GH as GitHub Actions Runner
participant Repo as Repository
participant Dotnet as dotnet CLI
rect rgb(250,250,255)
GH->>Repo: checkout
GH->>Dotnet: setup dotnet (existing)
end
Note right of GH: For each matrix value (npgsql-version)
rect rgb(245,255,240)
GH->>GH: set NPGSQL_VERSION = matrix.npgsql-version
GH->>Repo: cd by-language/csharp-efcore or csharp-npgsql
alt NPGSQL_VERSION == "prerelease"
GH->>Dotnet: dotnet add package <Package> --prerelease
else NPGSQL_VERSION == "latest"
GH->>Dotnet: dotnet add package <Package> --version=*
else
GH->>Dotnet: dotnet add package <Package> --version=<NPGSQL_VERSION>
end
GH->>Dotnet: dotnet list package
GH->>Dotnet: dotnet test
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
18f367f to
c483007
Compare
c483007 to
2568003
Compare
With the drawback of introducing redundancies by retiring the use of the universal test runner `ngr` in this case, the CI workflow recipe gains the benefit of being able to directly manipulate the version numbers of dependency packages. This improves the setup, because the test suite can now be validated against pre-release versions of the Npgsql package. Npgsql is important for CrateDB, because the .NET connectivity relies on it, provided by its PostgreSQL wire compatibility.
2568003 to
5a88858
Compare
About
Improve integration testing with Npgsql.
Details
With the drawback of introducing redundancies by retiring the use of the universal test runner
ngrin this case, the CI workflow recipe gains the benefit of being able to directly manipulate the version numbers of dependency packages.This improves the setup, because the test suite can now be validated against pre-release versions of the Npgsql package.
Npgsql is important for CrateDB, because the .NET connectivity relies on it, provided by its PostgreSQL wire compatibility.