Optional persistence of step data on flow back transition#248
Open
linxlad wants to merge 10 commits intocraue:masterfrom
Open
Optional persistence of step data on flow back transition#248linxlad wants to merge 10 commits intocraue:masterfrom
linxlad wants to merge 10 commits intocraue:masterfrom
Conversation
…the flow is transitioned backwards. If persistence on backwards transition is enabled and the current request transition is 'back' then persist the current step data to storage.
Added previous step.
Indented to match file formatting.
Updated comment to actually match what it does.
Updated comment to match others.
Author
|
Please see gif recording of this PR in action: |
|
Hi, |
Added setter and is methods for persistOnBackTransition.
Author
|
@Filoz Thanks for the suggestion. I have added those methods :) |
Actually don't need to set the form data as it is just getting the form name.
Author
|
@craue Does this look ok? :) |
Author
|
@craue Been nearly 6 months now. Is this git abandoned? |
Owner
|
Please, can we have this pull request? |
Author
Owner
|
Still, there are no tests covering this functionality, so I cannot merge it yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added optional class property and logic for step data persistence if the flow is transitioned backwards. If persistence on backwards transition is enabled and the current request transition is 'back' then persist the current step data to storage.