Skip to content

Replace dynamic with type parameter #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
prasmussen wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Replace dynamic with type parameter #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions lib/src/dropdown.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ class DropdownFormField<T> extends StatefulWidget {
final InputDecoration? decoration;
final Color? dropdownColor;
final DropdownEditingController<T>? controller;
final void Function(T item)? onChanged;
final void Function(T? item)? onChanged;
final void Function(T?)? onSaved;
final String? Function(T?)? validator;

Expand Down Expand Up @@ -100,7 +100,7 @@ class DropdownFormField<T> extends StatefulWidget {
DropdownFormFieldState createState() => DropdownFormFieldState<T>();
}

class DropdownFormFieldState<T> extends State<DropdownFormField>
class DropdownFormFieldState<T> extends State<DropdownFormField<T>>
with SingleTickerProviderStateMixin {
final FocusNode _widgetFocusNode = FocusNode();
final FocusNode _searchFocusNode = FocusNode();
Expand All @@ -111,8 +111,7 @@ class DropdownFormFieldState<T> extends State<DropdownFormField>
final DropdownEditingController<T>? _controller =
DropdownEditingController<T>();

final Function(T?, T?) _selectedFn =
(dynamic item1, dynamic item2) => item1 == item2;
final Function(T?, T?) _selectedFn = (T? item1, T? item2) => item1 == item2;

bool get _isEmpty => _selectedItem == null;
bool _isFocused = false;
Expand All @@ -126,7 +125,7 @@ class DropdownFormFieldState<T> extends State<DropdownFormField>
Timer? _debounce;
String? _lastSearchString;

DropdownEditingController<dynamic>? get _effectiveController =>
DropdownEditingController<T>? get _effectiveController =>
widget.controller ?? _controller;

DropdownFormFieldState() : super() {}
Expand Down
2 changes: 1 addition & 1 deletion lib/src/text-dropdown.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ class TextDropdownFormField extends StatelessWidget {
final List<String> options;
final InputDecoration? decoration;
final DropdownEditingController<String>? controller;
final void Function(String item)? onChanged;
final void Function(String? item)? onChanged;
final void Function(String?)? onSaved;
final String? Function(String?)? validator;
final bool Function(String item, String str)? filterFn;
Expand Down