This repository was archived by the owner on Feb 23, 2022. It is now read-only.
Fix can't modify frozen String error#38
Open
andyklimczak wants to merge 2 commits intocraysiii:masterfrom
Open
Fix can't modify frozen String error#38andyklimczak wants to merge 2 commits intocraysiii:masterfrom
andyklimczak wants to merge 2 commits intocraysiii:masterfrom
Conversation
Cannot use shovel method with frozen strings
z0rk1-j0rd
approved these changes
Feb 26, 2020
|
Hello, what about this PR? There is no works without it on Ruby 2.7.* = ( |
Owner
|
Apologies,
I have been very busy with work and have not had time to pay attention to my personal projects in a long time. I will review the PR over the weekend and publish if it looks good.
…________________________________
From: Mikhail Zadera <notifications@github.com>
Sent: Wednesday, September 16, 2020 10:47:11 PM
To: craysiii/binance <binance@noreply.github.com>
Cc: Charles Ray Shisler III <charles@cray.io>; Review requested <review_requested@noreply.github.com>
Subject: Re: [craysiii/binance] Fix can't modify frozen String error (#38)
Hello, what about this PR? There is no works without it on Ruby 2.7.* = (
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub<#38 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAKSZT5TVYTV32GAATOYORLSGGPF7ANCNFSM4KZ6TVKQ>.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cannot use shovel method with frozen strings in Ruby 2.7