Merge pull request #784 from crazywhalecc/revert/embed-option

Revert build-embed option as boolean

Author: henderkes

src/SPC/command/BuildPHPCommand.php

@@ -31,7 +31,7 @@ public function configure(): void
         $this->addOption('build-micro', null, null, 'Build micro SAPI');
         $this->addOption('build-cli', null, null, 'Build cli SAPI');
         $this->addOption('build-fpm', null, null, 'Build fpm SAPI (not available on Windows)');
-        $this->addOption('build-embed', null, InputOption::VALUE_OPTIONAL, 'Build embed SAPI (not available on Windows)');
+        $this->addOption('build-embed', null, null, 'Build embed SAPI (not available on Windows)');
         $this->addOption('build-frankenphp', null, null, 'Build FrankenPHP SAPI (not available on Windows)');
         $this->addOption('build-all', null, null, 'Build all SAPI');
         $this->addOption('no-strip', null, null, 'build without strip, keep symbols to debug');
@@ -289,18 +289,7 @@ private function parseRules(array $shared_extensions = []): int
         $rule |= ($this->getOption('build-cli') ? BUILD_TARGET_CLI : BUILD_TARGET_NONE);
         $rule |= ($this->getOption('build-micro') ? BUILD_TARGET_MICRO : BUILD_TARGET_NONE);
         $rule |= ($this->getOption('build-fpm') ? BUILD_TARGET_FPM : BUILD_TARGET_NONE);
-        $embed = $this->getOption('build-embed');
-        $embed = match ($embed) {
-            null => getenv('SPC_CMD_VAR_PHP_EMBED_TYPE') ?: 'static',
-            'static' => 'static',
-            'shared' => 'shared',
-            false => false,
-            default => throw new WrongUsageException('Invalid --build-embed option, please use --build-embed[=static|shared]'),
-        };
-        if ($embed) {
-            $rule |= BUILD_TARGET_EMBED;
-            f_putenv('SPC_CMD_VAR_PHP_EMBED_TYPE=' . ($embed === 'static' ? 'static' : 'shared'));
-        }
+        $rule |= $this->getOption('build-embed') || !empty($shared_extensions) ? BUILD_TARGET_EMBED : BUILD_TARGET_NONE;
         $rule |= ($this->getOption('build-frankenphp') ? (BUILD_TARGET_FRANKENPHP | BUILD_TARGET_EMBED) : BUILD_TARGET_NONE);
         $rule |= ($this->getOption('build-all') ? BUILD_TARGET_ALL : BUILD_TARGET_NONE);
         return $rule;