Add shared-extensions, frankenphp and zts to build-unix workflow#1062
Open
N-Silbernagel wants to merge 1 commit intocrazywhalecc:mainfrom
Open
Add shared-extensions, frankenphp and zts to build-unix workflow#1062N-Silbernagel wants to merge 1 commit intocrazywhalecc:mainfrom
N-Silbernagel wants to merge 1 commit intocrazywhalecc:mainfrom
Conversation
henderkes
requested changes
Mar 16, 2026
| ALL_EXTS="$ALL_EXTS,$SHARED_EXTS" | ||
| case "${{ inputs.os }}" in | ||
| linux-x86_64|linux-aarch64) | ||
| echo "Shared extensions (e.g. xdebug) require glibc/macOS targets. Use linux-*-glibc or macos-*." |
Collaborator
There was a problem hiding this comment.
that's not true, shared extensions work with musl too if you set SPC_TARGET="x86_64-linux-musl -dynamic".
Collaborator
There was a problem hiding this comment.
or on alpine with SPC_MUSL_DYNAMIC=true
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds options for shared-extensions, build-frankenphp and enable-zts to the build-unix workflow. The change enables me to build a (mostly) static frankenphp together with xdebug without installing any tools. I'm hoping this also benefits others.
Needed to add "getenv('SPC_CMD_VAR_PHP_MAKE_EXTRA_LDFLAGS') ?: ''" because "getenv('SPC_CMD_VAR_PHP_MAKE_EXTRA_LDFLAGS')" returns false in gh action where the env var is not set.
Checklist before merging
If you modified
*.phpor*.json, run them locally to ensure your changes are valid:composer cs-fixcomposer analysecomposer testbin/spc dev:sort-configThis fails, but already does so on commit 4625c6a
If it's an extension or dependency update, please ensure the following:
src/globals/test-extensions.php.extension testortest extensionsto trigger full test suite.