Skip to content

Conversation

@mainframe98
Copy link
Contributor

@mainframe98 mainframe98 commented Feb 10, 2025

What does this PR do?

Extends the exception thrown when the sanity check for the cli target fails by adding the return code and output generated by the PHP binary (fixes #604).

Checklist before merging

If your PR involves the changes mentioned below and completed the action, please tick the corresponding option.
If a modification is not involved, please skip it directly.

  • If it's an extension or dependency update, make sure adding related extensions in src/global/test-extensions.php.
  • If you changed the behavior of static-php-cli, update docs in ./docs/.
  • If you updated config/xxx.json content, run bin/spc dev:sort-config xxx.

@crazywhalecc crazywhalecc added new feature New feature or request kind/framework Issues related to CLI app framework labels Feb 11, 2025
@crazywhalecc crazywhalecc merged commit 15af034 into crazywhalecc:main Feb 11, 2025
15 checks passed
@mainframe98 mainframe98 deleted the report-cli-sanity-check-failure-reason branch February 11, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/framework Issues related to CLI app framework new feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The php cli sanity check should report why it failed

2 participants