Fix PIC errors when building libphp.so | extensive extension building rework #726

henderkes · 2025-05-15T07:49:31Z

What does this PR do?

fix building of shared libphp.so with icu and a few other extensions

closes #738
closes #735
closes #725
closes #720
closes #749
closes #744
enables #724

Checklist before merging

If your PR involves the changes mentioned below and completed the action, please tick the corresponding option.
If a modification is not involved, please skip it directly.

If you modified *.php, run composer cs-fix at local machine.

henderkes · 2025-05-15T08:38:00Z

Success:

Installing PHP SAPI module:       embed
[08:28:41] [I] Patching phpize prefix
[08:28:41] [I] Replacing file with type[1]: /home/m/static-php-cli/buildroot/bin/phpize
[08:28:41] [I] Replacing file with type[1]: /home/m/static-php-cli/buildroot/bin/phpize
[08:28:41] [I] Patching php-config prefix and libs order
[08:28:41] [I] running cli sanity check
[08:28:41] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n -r "echo \"hello\";"
[08:28:41] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/unix/UnixBuilderBase.php:143
[08:28:41] [I] testing ext: apcu
[08:28:41] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n --ri "apcu"
[08:28:41] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:214
[08:28:41] [I] testing ext: bcmath
[08:28:41] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n --ri "bcmath"
[08:28:41] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:214
[08:28:41] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n -r "assert(function_exists('bcscale'));"
[08:28:41] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:227
[08:28:41] [I] testing ext: calendar
[08:28:41] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n --ri "calendar"
[08:28:41] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:214
[08:28:41] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n -r "assert(function_exists('cal_info'));assert(is_array(cal_info(0)));"
[08:28:41] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:227
[08:28:41] [I] testing ext: ctype
[08:28:41] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n --ri "ctype"
[08:28:41] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:214
[08:28:41] [I] testing ext: curl
[08:28:41] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n --ri "curl"
[08:28:41] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:214
[08:28:41] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n -r "assert(function_exists('curl_init'));assert(function_exists('curl_setopt'));assert(function_exists('curl_exec'));assert(function_exists('curl_close'));\$curl_version = curl_version();if (stripos(\$curl_version['ssl_version'], 'schannel') "'!'"== false) {    \$curl = curl_init();    curl_setopt(\$curl, CURLOPT_URL, 'https://example.com/');    curl_setopt(\$curl, CURLOPT_RETURNTRANSFER, 1);    curl_setopt(\$curl, CURLOPT_HEADER, 0);    \$data = curl_exec(\$curl);    curl_close(\$curl);    assert(\$data "'!'"== false);}"
[08:28:41] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:227
[08:28:41] [I] testing ext: dba
[08:28:41] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n --ri "dba"
[08:28:41] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:214
[08:28:41] [I] testing ext: dom
[08:28:41] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n --ri "dom"
[08:28:41] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:214
[08:28:41] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n -r "assert(class_exists('\DOMDocument'));\$doc = new DOMDocument();\$doc->loadHtml('<html><head><meta charset=\"UTF-8\"><meta http-equiv=\"Content-Type\" content=\"text/html; charset=UTF-8\"></head><body id=\"app\">Hello</body></html>');assert(\$doc->getElementById('app')->nodeValue === 'Hello');"
[08:28:41] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:227
[08:28:41] [I] testing ext: exif
[08:28:41] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n --ri "exif"
[08:28:41] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:214
[08:28:42] [I] testing ext: fileinfo
[08:28:42] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n --ri "fileinfo"
[08:28:42] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:214
[08:28:42] [I] testing ext: filter
[08:28:42] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n --ri "filter"
[08:28:42] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:214
[08:28:42] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n -r "assert(function_exists('filter_var'));"
[08:28:42] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:227
[08:28:42] [I] testing ext: zlib
[08:28:42] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n --ri "zlib"
[08:28:42] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:214
[08:28:42] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n -r "assert(function_exists('gzcompress'));assert(gzdecode(gzencode('aaa')) === 'aaa');"
[08:28:42] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:227
[08:28:42] [I] testing ext: gd
[08:28:42] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n --ri "gd"
[08:28:42] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:214
[08:28:42] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n -r "assert(function_exists('gd_info'));\$info = gd_info();assert(\$info['PNG Support'] ?? false);assert(\$info['GIF Create Support'] ?? false);assert(\$info['GIF Read Support'] ?? false);"
[08:28:42] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:227
[08:28:42] [I] testing ext: gettext
[08:28:42] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n --ri "gettext"
[08:28:42] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:214
[08:28:42] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n -r "assert(function_exists('gettext'));assert(function_exists('bindtextdomain'));assert(function_exists('textdomain'));if ("'!'"is_dir('locale/en_US/LC_MESSAGES/')) {    mkdir('locale/en_US/LC_MESSAGES/', 0755, true);}if ("'!'"file_exists('locale/en_US/LC_MESSAGES/test.mo')) {    \$mo = '3hIElQAAAAACAAAAHAAAACwAAAAFAAAAPAAAAAAAAABQAAAABgAAAFEAAAAXAQAAWAAAAAcAAABwAQAAAQAAAAAAAAAAAAAAAgAAAAAAAAAA56S65L6LAFByb2plY3QtSWQtVmVyc2lvbjogUEFDS0FHRSBWRVJTSU9OClJlcG9ydC1Nc2dpZC1CdWdzLVRvOiAKUE8tUmV2aXNpb24tRGF0ZTogWUVBUi1NTy1EQSBITzpNSStaT05FCkxhc3QtVHJhbnNsYXRvcjogRlVMTCBOQU1FIDxFTUFJTEBBRERSRVNTPgpMYW5ndWFnZS1UZWFtOiBMQU5HVUFHRSA8TExAbGkub3JnPgpMYW5ndWFnZTogCk1JTUUtVmVyc2lvbjogMS4wCkNvbnRlbnQtVHlwZTogdGV4dC9wbGFpbjsgY2hhcnNldD1VVEYtOApDb250ZW50LVRyYW5zZmVyLUVuY29kaW5nOiA4Yml0CgBFeGFtcGxlAA==';    file_put_contents('locale/en_US/LC_MESSAGES/test.mo', base64_decode(\$mo));}putenv('LANG=en_US');assert(setlocale(LC_ALL, 'en_US.utf-8') === 'en_US.utf-8');\$domain = 'test';bindtextdomain(\$domain, 'locale/');textdomain(\$domain);assert(gettext(json_decode('\"\u793a\u4f8b\"', true)) === 'Example');"
[08:28:42] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:227
[08:28:42] [I] testing ext: iconv
[08:28:42] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n --ri "iconv"
[08:28:42] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:214
[08:28:42] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n -r "assert(function_exists('iconv'));assert(iconv('UTF-8', 'CP437', 'foo') === 'foo');"
[08:28:42] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:227
[08:28:42] [I] testing ext: session
[08:28:42] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n --ri "session"
[08:28:42] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:214
[08:28:42] [I] testing ext: igbinary
[08:28:42] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n --ri "igbinary"
[08:28:42] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:214
[08:28:42] [I] testing ext: imagick
[08:28:42] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n --ri "imagick"
[08:28:42] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:214
[08:28:42] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n -r "assert(class_exists('Imagick'));assert(Imagick::queryFormats('AVIF') "'!'"== []);assert(Imagick::queryFormats('HEIF') "'!'"== []);assert(Imagick::queryFormats('HEIC') "'!'"== []);assert(Imagick::queryFormats('WEBP') "'!'"== []);assert(Imagick::queryFormats('JPEG') "'!'"== []);assert(Imagick::queryFormats('PNG') "'!'"== []);assert(Imagick::queryFormats('TIFF') "'!'"== []);"
[08:28:42] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:227
[08:28:42] [I] testing ext: intl
[08:28:42] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n --ri "intl"
[08:28:42] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:214
[08:28:42] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n -r "assert(class_exists(NumberFormatter::class));assert(function_exists('locale_get_default'));\$fmt = new NumberFormatter('de-DE', NumberFormatter::DECIMAL);assert(strval(\$fmt->parse('1.100')) === '1100');"
[08:28:42] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:227
[08:28:42] [I] testing ext: xml
[08:28:42] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n --ri "xml"
[08:28:42] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:214
[08:28:42] [I] testing ext: libxml
[08:28:42] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n --ri "libxml"
[08:28:42] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:214
[08:28:42] [I] testing ext: mbstring
[08:28:42] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n --ri "mbstring"
[08:28:42] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:214
[08:28:42] [I] testing ext: mbregex
[08:28:42] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n --ri "mbstring" | grep regex
[08:28:42] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/extension/mbregex.php:29
[08:28:42] [I] testing ext: mysqlnd
[08:28:42] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n --ri "mysqlnd"
[08:28:42] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:214
[08:28:42] [I] testing ext: mysqli
[08:28:42] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n --ri "mysqli"
[08:28:42] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:214
[08:28:42] [I] testing ext: opcache
[08:28:42] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n --ri "Zend Opcache"
[08:28:42] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:214
[08:28:42] [I] testing ext: openssl
[08:28:42] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n --ri "openssl"
[08:28:42] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:214
[08:28:42] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n -r "assert(function_exists('openssl_digest'));assert(openssl_digest('123456', 'md5') === 'e10adc3949ba59abbe56e057f20f883e');if (file_exists('/etc/ssl/openssl.cnf')) {    assert(file_get_contents('https://example.com/') "'!'"== false);}"
[08:28:42] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:227
[08:28:43] [I] testing ext: pcntl
[08:28:43] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n --ri "pcntl"
[08:28:43] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:214
[08:28:43] [I] testing ext: pdo
[08:28:43] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n --ri "pdo"
[08:28:43] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:214
[08:28:43] [I] testing ext: pdo_mysql
[08:28:43] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n --ri "pdo_mysql"
[08:28:43] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:214
[08:28:43] [I] testing ext: sqlite3
[08:28:43] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n --ri "sqlite3"
[08:28:43] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:214
[08:28:43] [I] testing ext: pdo_sqlite
[08:28:43] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n --ri "pdo_sqlite"
[08:28:43] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:214
[08:28:43] [I] testing ext: phar
[08:28:43] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n --ri "phar"
[08:28:43] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:214
[08:28:43] [I] testing ext: posix
[08:28:43] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n --ri "posix"
[08:28:43] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:214
[08:28:43] [I] testing ext: readline
[08:28:43] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n --ri "readline"
[08:28:43] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:214
[08:28:43] [I] testing ext: redis
[08:28:43] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n --ri "redis"
[08:28:43] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:214
[08:28:43] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n -r "assert(class_exists('\Redis'));"
[08:28:43] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:227
[08:28:43] [I] testing ext: simplexml
[08:28:43] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n --ri "simplexml"
[08:28:43] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:214
[08:28:43] [I] testing ext: sockets
[08:28:43] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n --ri "sockets"
[08:28:43] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:214
[08:28:43] [I] testing ext: sodium
[08:28:43] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n --ri "sodium"
[08:28:43] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:214
[08:28:43] [I] testing ext: ssh2
[08:28:43] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n --ri "ssh2"
[08:28:43] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:214
[08:28:43] [I] testing ext: tokenizer
[08:28:43] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n --ri "tokenizer"
[08:28:43] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:214
[08:28:43] [I] testing ext: zip
[08:28:43] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n --ri "zip"
[08:28:43] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:214
[08:28:44] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n -r "assert(class_exists('\ZipArchive'));"
[08:28:44] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:227
[08:28:44] [I] testing ext: xlswriter
[08:28:44] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n --ri "xlswriter"
[08:28:44] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:214
[08:28:44] [I] testing ext: xmlreader
[08:28:44] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n --ri "xmlreader"
[08:28:44] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:214
[08:28:44] [I] testing ext: xmlwriter
[08:28:44] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n --ri "xmlwriter"
[08:28:44] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:214
[08:28:44] [I] testing ext: xsl
[08:28:44] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n --ri "xsl"
[08:28:44] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:214
[08:28:44] [I] testing ext: zstd
[08:28:44] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n --ri "zstd"
[08:28:44] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:214
[08:28:44] [I] running embed sanity check
[08:28:44] [I] Entering dir: /home/m/static-php-cli/source/embed-test
[08:28:44] [I] [EXEC] gcc -o embed embed.c -fPIC -I/home/m/static-php-cli/buildroot/include -I/home/m/static-php-cli/buildroot/include/php -I/home/m/static-php-cli/buildroot/include/php/main -I/home/m/static-php-cli/buildroot/include/php/TSRM -I/home/m/static-php-cli/buildroot/include/php/Zend -I/home/m/static-php-cli/buildroot/include/php/ext -L/home/m/static-php-cli/buildroot/lib -lphp -lc -lxslt -lexslt -lsodium -lreadline -lsqlite3 -lonig -lMagick++-7.Q16HDRI -lMagickWand-7.Q16HDRI -lMagickCore-7.Q16HDRI -lzip -lheif -laom -lde265 -ltiff -lintl -lncurses -lfreetype -lbz2 -ljpeg -lturbojpeg -lwebp -lwebpdecoder -lwebpdemux -lwebpmux -lsharpyuv -lpng16 -lcurl -lzstd -lxml2 -licui18n -licuio -licuuc -licudata -liconv -lcharset -lbrotlidec -lbrotlienc -lbrotlicommon -lssh2 -lssl -lcrypto -lz -ldl -lpthread -lm -lresolv -lutil -lrt -lstdc++
[08:28:44] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/unix/UnixBuilderBase.php:191
[08:28:44] [I] Entering dir: /home/m/static-php-cli/source/embed-test
[08:28:44] [I] [EXEC] LD_LIBRARY_PATH=/home/m/static-php-cli/buildroot/lib:$LD_LIBRARY_PATH ./embed
[08:28:44] [I] Executed at: /home/m/static-php-cli/src/SPC/builder/unix/UnixBuilderBase.php:203
[08:28:44] [I]
[08:28:44] [I]    Build complete, used 176.334 s !
[08:28:44] [I]
[08:28:44] [I] Static php binary path: /home/m/static-php-cli/buildroot/bin/php

henderkes · 2025-05-15T11:29:57Z

closes #725

crazywhalecc · 2025-05-17T16:43:46Z

Ehhh....finally back, finished hard exam and day job.

It seems that there have been a lot of changes recently. I will review it soon. If there are any unfinished parts, you could put them in the draft.

henderkes · 2025-05-17T21:08:35Z

Welcome back! It's a part of preparing the project to build "all" shared extensions and libphp.so for deb/rpm packages. Most extensions build without any changes, but some take different arguments when building them shared.

I will wrap this up later today. There's still an unsolved problem where it seems that some shared extensions need other shared extensions to be built first, if they're both enabled. I.e. we cannot build event before sockets if they are both enabled. And there's a dependency on some shared extensions on others too, don cannot be built if xml wasn't also built before.

henderkes · 2025-05-18T02:55:03Z

I will leave this as it is for now. There are still some extensions similar to mysqlnd or libxml that cannot be built as a shared library as they don't even have a config.m4 file. There are also some extensions that currently fail building shared, like ldap. Dom and xmlreader/xmlwriter require xml to be built first, so we'll need a new "shared-ext-depends" key in the json and maybe some way to configure the build order even if two extensions are both selected, such as event and sockets. For sockets and a few others it also seems like they don't install the headers into buildroot/include/php/ext folder.

Too many things to do than is appropriate for this PR.

For now, all the extensions I've tested can be built statically into libphp.so.

henderkes · 2025-05-18T05:51:19Z

it's insane how many libraries ignore -fPIC in some places. postgresql too and it doesn't even understand --with-pic

src/SPC/builder/BuilderBase.php

henderkes · 2025-05-18T07:51:31Z

maybe we need to put -fpic -fPIC into CXXFLAGS too

crazywhalecc · 2025-06-11T16:17:11Z

I may found why mongodb and dom will cause embed test failed.....

MacOSBuilder re-archives the libphp.a, which extracts all *.o and archive again. (Linux doesn't need it)
During step 1, dom's document.o conflicts with mongodb's BSON/Document.o, and the result is missing symbol.
macOS is a case-insensitive operating system.

I remember that this re-archive process was to solve the problem that macOS could not directly use libphp.a in #153

But what surprised me even more is it took me so long to encounter the first error caused by duplicate object names. If there was a conflict, why didn't an error occur when there were so many files with the same name?

henderkes · 2025-06-11T16:57:59Z

we should use

ar -t | xargs ... ar -#. I use it in ngtcp2 because it puts dependent .a files in the ngtcp2.a, which macos linker does not understand.

henderkes · 2025-06-11T16:59:41Z

https://github.com/crazywhalecc/static-php-cli/blob/fix/icurel/src/SPC/builder/unix/library/ngtcp2.php#L49

henderkes · 2025-06-12T00:35:48Z

I'll spin up my fake macos docker image and test various extension combinations just in case. Linux is stable on centos 7, rhel 9, rhel 10 and ubuntu/musl. Alpine will work again with 8.3.23, the php-src issue was merged.

henderkes · 2025-06-12T01:44:49Z

glfw is failing to build, but everything else works.

crazywhalecc · 2025-06-12T03:00:01Z

Solved. The source dir getter for lib was using wrong dirname.

henderkes · 2025-06-12T03:02:45Z

I'm currently adding fastlz because memcached + yac both build it unless --with-system-fastlz is specified. The ld64 linker doesn't support -Wl,--allow-multiple-definition, so we'd either have to install lld or build fastlz beforehand.

crazywhalecc · 2025-06-12T03:08:10Z

Oh, btw we could use commit messages to trigger build tests. This would avoid redundant builds and ensure that the content of each test is controllable. WDYT?

henderkes · 2025-06-12T03:19:42Z

depends if we're running out of resources. if resource usage is fine, it's fine to keep testing every commit

henderkes · 2025-06-12T03:47:05Z

[03:45:35] [D] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:275
[03:45:35] [D] testing ext: memcached
[03:45:35] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n --ri "memcached"
[03:45:35] [D] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:262
[03:45:35] [D] testing ext: igbinary
[03:45:35] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n --ri "igbinary"
[03:45:35] [D] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:262
[03:45:35] [D] testing ext: yac
[03:45:35] [I] [EXEC] /home/m/static-php-cli/buildroot/bin/php -n --ri "yac"
[03:45:35] [D] Executed at: /home/m/static-php-cli/src/SPC/builder/Extension.php:262

henderkes · 2025-06-12T03:52:01Z

you should update the spc mirror of libmemcached, I updated away from the 11 year old library to the maintained fork

henderkes

Can't approve my own PR, but I've built all extensions (including memcached) in various rotations and they all build fine now on both macos 15 (x86_64) and linux.

config/env.ini

src/SPC/builder/unix/UnixBuilderBase.php

…os?)

henderkes · 2025-06-12T04:48:29Z

🥳

henderkes added 6 commits April 30, 2025 21:46

static compilation is not quite working yet

2c13eb2

lowercase

b3dacf9

format setEnv§

f5fffaf

fix icu for relocatable objects (required by libphp.so building)

2897fdd

fix libsodium with -fPIC too

03b634b

remove unused option

23ae3f6

henderkes added 10 commits May 15, 2025 19:52

ld library path for shared extension building

6fe8b59

remove static target for zip

9557c9e

remove static target for swoole

2200179

fix copy command with BUILD_MODULES_CONSTANT

b402b73

oopsie

1ae27c7

oopsie in opcache

8726736

fix shared bz2 build

76a9be2

refactor dom out to its own extension, fails shared build

05e9129

sockets doesn't install header?!

c1e91e1

shared dom ext requires xml

eab8c27

restore buildphp command

f88c10d

henderkes added 2 commits May 18, 2025 12:19

-fPIC for unixodbc

2ff3009

-fPIC for postgresql CFLAGS, but it's still erroring out

1fbd2c1

install headers and modules from shared extensions

bdd7642

henderkes commented May 18, 2025

View reviewed changes

src/SPC/builder/BuilderBase.php Outdated Show resolved Hide resolved

henderkes added 2 commits May 18, 2025 15:52

libxml2 pic...

ea7c145

Update test-extensions.php

1179237

this is not needed anymore

84fb354

I really got redundant test error

c0ea47c

crazywhalecc added 3 commits June 12, 2025 01:16

Fix macOS embed re-archive bug

2ea8a7e

Add frameworks for extension

e0734fe

Revert ext-matrix-tests and test-extensions

28e5e58

fix attempted ar deletions when building shared libphp

e2efaab

Fix glfw source path

bfba598

add fastlz, libmemcached for linux

089b94d

fix phpstan

fcfbb59

update default flags

01ab0d3

henderkes commented Jun 12, 2025

View reviewed changes

henderkes requested a review from crazywhalecc June 12, 2025 04:02

crazywhalecc reviewed Jun 12, 2025

View reviewed changes

config/env.ini Outdated Show resolved Hide resolved

config/env.ini Show resolved Hide resolved

config/env.ini Outdated Show resolved Hide resolved

config/env.ini Outdated Show resolved Hide resolved

src/SPC/builder/unix/UnixBuilderBase.php Outdated Show resolved Hide resolved

henderkes added 2 commits June 12, 2025 11:40

update default env (shouldn't we pass -fpic to default c flags on mac…

d9f7aa7

…os?)

oops, don't pass -fpic to CPPflags, I misread it as CXXflags

0ee9a0c

crazywhalecc approved these changes Jun 12, 2025

View reviewed changes

henderkes merged commit 289f4b3 into main Jun 12, 2025
10 checks passed

crazywhalecc deleted the fix/icurel branch June 12, 2025 05:05

Uh oh!

Fix PIC errors when building libphp.so | extensive extension building rework #726

Fix PIC errors when building libphp.so | extensive extension building rework #726

Uh oh!

Conversation

henderkes commented May 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Checklist before merging

Uh oh!

henderkes commented May 15, 2025 • edited by crazywhalecc Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

henderkes commented May 15, 2025

Uh oh!

crazywhalecc commented May 17, 2025

Uh oh!

henderkes commented May 17, 2025

Uh oh!

henderkes commented May 18, 2025

Uh oh!

henderkes commented May 18, 2025

Uh oh!

Uh oh!

henderkes commented May 18, 2025

Uh oh!

crazywhalecc commented Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

henderkes commented Jun 11, 2025

Uh oh!

henderkes commented Jun 11, 2025

Uh oh!

henderkes commented Jun 12, 2025

Uh oh!

henderkes commented Jun 12, 2025

Uh oh!

crazywhalecc commented Jun 12, 2025

Uh oh!

henderkes commented Jun 12, 2025

Uh oh!

crazywhalecc commented Jun 12, 2025

Uh oh!

henderkes commented Jun 12, 2025

Uh oh!

henderkes commented Jun 12, 2025

Uh oh!

henderkes commented Jun 12, 2025

Uh oh!

henderkes left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

henderkes commented Jun 12, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

henderkes commented May 15, 2025 •

edited

Loading

henderkes commented May 15, 2025 •

edited by crazywhalecc

Loading

crazywhalecc commented Jun 11, 2025 •

edited

Loading