Conversation
Owner
|
Currently LockFile is only managing source and downloads, it's not managing How about deleting the module directory here only if it is detected that this build contains a shared extension? |
Collaborator
Author
|
if it doesn't contain a shared extension, I don't think it's even created in the first place, so that would only add unnecessary code |
crazywhalecc
approved these changes
Jun 19, 2025
Owner
crazywhalecc
left a comment
crazywhalecc
left a comment
There was a problem hiding this comment.
At this point, it seems appropriate to delete it here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I would like to integrate this into the LockFile somehow, but I'm not sure how.
please feel free to move it to the right location