Skip to content

Change the patch position for -release module suffix#791

Merged
crazywhalecc merged 1 commit intomainfrom
fix/configure-cmd-patch
Jun 20, 2025
Merged

Change the patch position for -release module suffix#791
crazywhalecc merged 1 commit intomainfrom
fix/configure-cmd-patch

Conversation

@crazywhalecc
Copy link
Owner

What does this PR do?

Fix #788

Checklist before merging

If your PR involves the changes mentioned below and completed the action, please tick the corresponding option.
If a modification is not involved, please skip it directly.

  • If you modified *.php or *.json, run them locally to ensure your changes are valid:
    • PHP_CS_FIXER_IGNORE_ENV=1 composer cs-fix
    • composer analyse
    • composer test
    • bin/spc dev:sort-config
  • If it's an extension or dependency update, please ensure the following:
    • Add your test combination to src/globals/test-extensions.php.
    • If adding new or fixing bugs, add commit message containing extension test or test extensions to trigger full test suite.

@crazywhalecc crazywhalecc requested a review from henderkes June 20, 2025 10:22
@henderkes
Copy link
Collaborator

henderkes commented Jun 20, 2025

why does that fix anything? I don't see how it breaks anything in the first place

edit: oh you linked the failed job, I see

@crazywhalecc crazywhalecc merged commit 1b4eb03 into main Jun 20, 2025
12 of 13 checks passed
@crazywhalecc crazywhalecc deleted the fix/configure-cmd-patch branch June 20, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] PHP Pack Lib failed

2 participants