Skip to content

Conversation

@henderkes
Copy link
Collaborator

What does this PR do?

we accidentally lost h3 support in the cmake refactor, this brings it back

Checklist before merging

If your PR involves the changes mentioned below and completed the action, please tick the corresponding option.
If a modification is not involved, please skip it directly.

  • If you modified *.php or *.json, run them locally to ensure your changes are valid:
    • PHP_CS_FIXER_IGNORE_ENV=1 composer cs-fix
    • composer analyse
    • composer test
    • bin/spc dev:sort-config
  • If it's an extension or dependency update, please ensure the following:
    • Add your test combination to src/globals/test-extensions.php.
    • If adding new or fixing bugs, add commit message containing extension test or test extensions to trigger full test suite.

@henderkes
Copy link
Collaborator Author

henderkes commented Jun 21, 2025

we need to either remove the test, or make ngtcp2/nghttp3/nghttp2 required though

@henderkes henderkes requested a review from crazywhalecc June 21, 2025 03:58
@henderkes henderkes merged commit 1a42963 into main Jun 21, 2025
9 checks passed
@crazywhalecc crazywhalecc deleted the fix/curl-h3 branch June 21, 2025 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants