-
-
Notifications
You must be signed in to change notification settings - Fork 308
Add PHP 8.5 initial support #819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
5f2459a
ec959f6
b9e096a
88cf018
d3f8e94
dc8f7de
1ce3ba0
5838c87
f061259
fb106a3
85e89e4
973c8f0
0696acb
1ae0752
b9bec5b
4efb3df
e9dbeb1
ed67393
9ed3c8b
5f5d934
af10cac
0dfa6e6
357c04d
5f33a07
fcdb029
cb0ea67
6984c29
3c972ac
601444d
be85791
96a7aab
0496af4
1047d47
72beba7
4c54d99
5f9fe29
d3e8af2
e1c9240
07d66ad
6b38123
33d587e
451de4a
6b23f4b
7d05774
9487051
34edb6e
8b9b729
d6081ee
ac2eb3a
1c9fbdb
efa47af
cace504
2c5cf07
48a7d81
17ff5f6
22a8191
af62e55
f6eba32
65f7404
e14301d
3960a21
38725c2
d005353
c3e9a28
e6cf05d
e7fe91f
9a5a59d
6439268
f1a9a28
b644da8
2d6d25c
93001dc
430f436
3c09ba5
ea4905c
4cbe4ea
81e7a0c
4fb4e42
3789c7c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -30,6 +30,8 @@ public function getUnixConfigureArg(bool $shared = false): string | |
$args = '--with-openssl=' . ($shared ? 'shared,' : '') . BUILD_ROOT_PATH . $openssl_dir; | ||
if ($this->builder->getPHPVersionID() >= 80500 || !$this->builder->getOption('enable-zts')) { | ||
$args .= ' --with-openssl-argon2 OPENSSL_LIBS="-lz"'; | ||
} else { | ||
$args .= ' --without-openssl-argon2'; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is not needed, I mean that we must disable the fake password-argon2 extension in case openssl-argon2 is used. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah got it. But There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. with-openssl-argon2 implements the functionality of with-password-argon2. When both are defined, I'm not sure which backend will be used. Essentially we need to have this check in both extensions and use the openssl one if possible, but fall back to the coding contest implementation. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. According to config.m4 and function source, There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
We want it to use the openssl backend because it's the most well-maintained implementation. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks like if we enabled libargon2, it will use it first. Otherwise it will search from zend bucket. Anyway, I don't think we have to adjust pwhash function and dependency here. But if we could confirm and validate that openssl is able to cover it, we could make There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Well, only from php 8.4 for NTS and 8.5 for ZTS sadly. My point is that we should let openssl be the backend for the password_hash function if possible. I'll look into it tomorrow. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
} | ||
return $args; | ||
} | ||
|
Uh oh!
There was an error while loading. Please reload this page.