Skip to content

Conversation

henderkes
Copy link
Collaborator

@henderkes henderkes commented Oct 8, 2025

What does this PR do?

switch readline to libedit backend so we don't force gpl-3 license on users

closes #918
closes #888

@henderkes henderkes requested a review from crazywhalecc October 8, 2025 07:47
Copy link
Owner

@crazywhalecc crazywhalecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason to remove SPC_CMD_PREFIX_PHP_MAKE? The rest looks good to me.

@henderkes
Copy link
Collaborator Author

Just a continuation of slimming down env.ini. Optimally, we only want to expose env variables that would make sense to change as a user. The make command doesn't make sense to change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: lib_libiconv_0 contains GPL-3 license instead of LGPL Precompiled Musl PHP Binaries don't support php -a

2 participants