Skip to content

Fix: translation inconsistency in CC 4.0 zh_Hans translations #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
WaitSpringQW wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix: translation inconsistency in CC 4.0 zh_Hans translations #235

WaitSpringQW wants to merge 3 commits into from

Conversation

@WaitSpringQW
Copy link

@WaitSpringQW WaitSpringQW commented Feb 7, 2025 •
edited by TimidRobot
Loading

Fixes

Description

  • 例外与限制 → 例外和限制

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin 
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@WaitSpringQW WaitSpringQW requested review from a team as code owners February 7, 2025 14:04
@WaitSpringQW WaitSpringQW requested review from TimidRobot and possumbilities and removed request for a team February 7, 2025 14:04
@netlify
Copy link

netlify bot commented Feb 7, 2025 •
edited
Loading

✅ Deploy Preview for cc-legal-tools ready!

Name Link
🔨 Latest commit 6ac06d7
🔍 Latest deploy log https://app.netlify.com/sites/cc-legal-tools/deploys/67a612db7bfb400008b61ab4
😎 Deploy Preview https://deploy-preview-235--cc-legal-tools.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

TimidRobot
TimidRobot requested changes Oct 17, 2025
View reviewed changes
Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove all of the changes within docs/. The contents of this directory are generated by the CC Legal Tools application.

Please remove all of the changes within legacy/. These files are no longer used.

With the changes above, only the following files will have changes:

  1. legacy/legalcode/by-nc-nd_4.0_zh-Hans.html
  2. legacy/legalcode/by-nc-sa_4.0_zh-Hans.html
  3. legacy/legalcode/by-nc_4.0_zh-Hans.html
  4. legacy/legalcode/by-nd_4.0_zh-Hans.html
  5. legacy/legalcode/by-sa_4.0_zh-Hans.html
  6. legacy/legalcode/by_4.0_zh-Hans.html

@netlify
Copy link

netlify bot commented Oct 18, 2025 •
edited
Loading

✅ Deploy Preview for cc-legal-tools ready!

Name Link
🔨 Latest commit 987479e
🔍 Latest deploy log https://app.netlify.com/projects/cc-legal-tools/deploys/68f32c7b0a81b60008b11be9
😎 Deploy Preview https://deploy-preview-235--cc-legal-tools.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@WaitSpringQW
Copy link
Author

WaitSpringQW commented Oct 20, 2025

Please remove all of the changes within docs/. The contents of this directory are generated by the CC Legal Tools application.

Please remove all of the changes within legacy/. These files are no longer used.

With the changes above, only the following files will have changes:

  1. legacy/legalcode/by-nc-nd_4.0_zh-Hans.html
  2. legacy/legalcode/by-nc-sa_4.0_zh-Hans.html
  3. legacy/legalcode/by-nc_4.0_zh-Hans.html
  4. legacy/legalcode/by-nd_4.0_zh-Hans.html
  5. legacy/legalcode/by-sa_4.0_zh-Hans.html
  6. legacy/legalcode/by_4.0_zh-Hans.html

Thank you for your suggestion, and I've pushed revised commit.

@TimidRobot
Copy link
Member

TimidRobot commented Oct 21, 2025 •
edited
Loading

My errors struck through:

Please remove all of the changes within docs/. The contents of this directory are generated by the CC Legal Tools application.

Please remove all of the changes within legacy/. These files are no longer used.

With the changes above, only the following files will have changes:
1. legacy/legalcode/by-nc-nd_4.0_zh-Hans.html
2. legacy/legalcode/by-nc-sa_4.0_zh-Hans.html
3. legacy/legalcode/by-nc_4.0_zh-Hans.html
4. legacy/legalcode/by-nd_4.0_zh-Hans.html
5. legacy/legalcode/by-sa_4.0_zh-Hans.html
6. legacy/legalcode/by_4.0_zh-Hans.html

Thank you for your suggestion, and I've pushed revised commit.

Oh no! I did a bad job of documenting the requested changes. Please accept my apologies 🙏🏻

I should have written:

With the changes above, only the following files will have changes:

  1. legalcode/zh_Hans/LC_MESSAGES/by-nc-nd_40.mo
  2. legalcode/zh_Hans/LC_MESSAGES/by-nc-nd_40.po
  3. legalcode/zh_Hans/LC_MESSAGES/by-nc-sa_40.mo
  4. legalcode/zh_Hans/LC_MESSAGES/by-nc-sa_40.po
  5. legalcode/zh_Hans/LC_MESSAGES/by-nc_40.mo
  6. legalcode/zh_Hans/LC_MESSAGES/by-nc_40.po
  7. legalcode/zh_Hans/LC_MESSAGES/by-nd_40.mo
  8. legalcode/zh_Hans/LC_MESSAGES/by-nd_40.po
  9. legalcode/zh_Hans/LC_MESSAGES/by-sa_40.mo
  10. legalcode/zh_Hans/LC_MESSAGES/by-sa_40.po
  11. legalcode/zh_Hans/LC_MESSAGES/by_40.mo
  12. legalcode/zh_Hans/LC_MESSAGES/by_40.po

@WaitSpringQW
Copy link
Author

WaitSpringQW commented Oct 24, 2025 •
edited
Loading

My errors struck through:

Please remove all of the changes within docs/. The contents of this directory are generated by the CC Legal Tools application.
Please remove all of the changes within legacy/. These files are no longer used.
With the changes above, only the following files will have changes:
1. legacy/legalcode/by-nc-nd_4.0_zh-Hans.html
2. legacy/legalcode/by-nc-sa_4.0_zh-Hans.html
3. legacy/legalcode/by-nc_4.0_zh-Hans.html
4. legacy/legalcode/by-nd_4.0_zh-Hans.html
5. legacy/legalcode/by-sa_4.0_zh-Hans.html
6. legacy/legalcode/by_4.0_zh-Hans.html

Thank you for your suggestion, and I've pushed revised commit.

Oh no! I did a bad job of documenting the requested changes. Please accept my apologies 🙏🏻

I should have written:

With the changes above, only the following files will have changes:

  1. legalcode/zh_Hans/LC_MESSAGES/by-nc-nd_40.mo
  2. legalcode/zh_Hans/LC_MESSAGES/by-nc-nd_40.po
  3. legalcode/zh_Hans/LC_MESSAGES/by-nc-sa_40.mo
  4. legalcode/zh_Hans/LC_MESSAGES/by-nc-sa_40.po
  5. legalcode/zh_Hans/LC_MESSAGES/by-nc_40.mo
  6. legalcode/zh_Hans/LC_MESSAGES/by-nc_40.po
  7. legalcode/zh_Hans/LC_MESSAGES/by-nd_40.mo
  8. legalcode/zh_Hans/LC_MESSAGES/by-nd_40.po
  9. legalcode/zh_Hans/LC_MESSAGES/by-sa_40.mo
  10. legalcode/zh_Hans/LC_MESSAGES/by-sa_40.po
  11. legalcode/zh_Hans/LC_MESSAGES/by_40.mo
  12. legalcode/zh_Hans/LC_MESSAGES/by_40.po

Not to worry. If you look into files changed by the PR, you will find that only aformentioned files were changed; and changes on other files were reverted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TimidRobot TimidRobot TimidRobot requested changes

@possumbilities possumbilities Awaiting requested review from possumbilities possumbilities is a code owner automatically assigned from creativecommons/technology

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

TimidRobot
Status: In review

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] Translation inconsistency in CC 4.0 zh_Hans translations

2 participants

@WaitSpringQW @TimidRobot