-
-
Notifications
You must be signed in to change notification settings - Fork 136
fix scrollable section bug #372 #374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix scrollable section bug #372 #374
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a scrollable section bug (#372) by removing the fixed width constraint on the body element for screens with a minimum width of 1500px, allowing content to use the full available width on standard laptop screens instead of being constrained to a boxed layout.
Key Changes:
- Commented out fixed width constraint (
width: 1500px) and centering (margin: 0 auto) for large screens to enable responsive full-width layout
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| padding: 0; | ||
| width: 90%; | ||
| margin: 0 var(--vocabulary-page-edges-space) 6em; | ||
| padding: 0 5%; |
Copilot
AI
Dec 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The margin value has been changed from using the CSS variable var(--vocabulary-page-edges-space) to a hardcoded 5% value in the padding. While functionally equivalent (since the variable is defined as 5%), using the CSS variable would maintain consistency with the rest of the codebase and make future spacing adjustments easier to manage from a single location. Consider using padding: 0 var(--vocabulary-page-edges-space) instead of padding: 0 5%.
| padding: 0 5%; | |
| padding: 0 var(--vocabulary-page-edges-space); |
Fixes
Description
Removed the fixed width constraint on the body element for screens >= 1500px, allowing full-width layout on standard laptop screens instead of the boxed appearance.
Technical details
Commented out
width: 1500pxandmargin: 0 autoin the@media (min-width: 1500px)query in vocabulary.css to enable responsive full-width layout.Tests
Screenshots
Checklist
Update index.md).mainormaster).Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin