-
-
Notifications
You must be signed in to change notification settings - Fork 136
added clear filters button and improve accessibility in resource filters #375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR enhances accessibility for resource filters by adding ARIA attributes, keyboard navigation support, and a "Clear all filters" button to improve the experience for screen reader and keyboard users.
Key Changes:
- Added semantic ARIA roles and labels to filter sections for better screen reader support
- Implemented visible focus indicators and keyboard navigation for checkboxes
- Created a "Clear all filters" button that appears when filters are active
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| docs/_pages/all.html | Added ARIA attributes (role, aria-label, aria-labelledby) to filter sidebar and sections, plus clear filters button HTML |
| docs/_assets/js/listing.js | Implemented logic to show/hide clear button based on active filters and handle click/keyboard events |
| docs/_assets/css/style.css | Added styling for clear button, focus indicators for checkboxes, and hover states for accessibility |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Fixes
Description
Enhanced category filter accessibility with ARIA labels, keyboard navigation support, focus indicators, and a "Clear all filters" button for improved screen reader and keyboard user experience.
Technical details
Added semantic ARIA roles and labels to filter sections, implemented CSS focus styles with high-contrast outlines, and created an accessible clear filters button with keyboard event handlers in listing.js.
Tests
Screenshots
Checklist
Update index.md).mainormaster).Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin