Allow options_limit for variables to set in plutono.ini to allow for more than 1000 entries#106
Open
TorstenGangUS wants to merge 1 commit intocredativ:mainfrom
Open
Allow options_limit for variables to set in plutono.ini to allow for more than 1000 entries#106TorstenGangUS wants to merge 1 commit intocredativ:mainfrom
TorstenGangUS wants to merge 1 commit intocredativ:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, plutono doesn't allow variables to have more than 1000 entries.
this pull request would allow that limit to be specified under via an entry in plutono.ini.datasources.options_limit
Not sure if that is the best path/name in plutono.ini for it to be specified. I am open to moving it/renaming anyway that makes sense inside of plutono.ini.
This will also have the side effect of also affect the max number of entries returned by all queries,
specifically because of,
metrics.go:62 MaxDataPoints: query.Get("maxDataPoints").MustInt64(hs.Cfg.MaxDataPoints) (assuming the query doesn't specify maxDataPoints)
this line was also the hardest part of figuring out how to not limit the items to 1000. Also, for some reason the way this limit works is it returns maxDataPoints * 10. This is noted in comment.
I have tested only tested this while using influxdb as that is my use case for needing this.