fix: comments on pull request

Signed-off-by: pranalidhanavade <[email protected]>

Author: pranalidhanavade

apps/api-gateway/src/verification/dto/request-proof.dto.ts

@@ -272,7 +272,7 @@ export class RequestProofDtoBase extends ProofPayload {
     autoAcceptProof: AutoAccept;
     version: string;
 }
-export class RequestProofDto extends RequestProofDtoBase {
+export class RequestProofDtoV1 extends RequestProofDtoBase {
   @ApiProperty({
     example: '32f54163-7166-48f1-93d8-ff217bdb0653'
   })  
@@ -283,7 +283,7 @@ export class RequestProofDto extends RequestProofDtoBase {
 }
 
 
-export class ProofRequestPayloadDto extends RequestProofDtoBase {
+export class RequestProofDtoV2 extends RequestProofDtoBase {
   @ApiProperty({
     example: ['32f54163-7166-48f1-93d8-ff217bdb0653']
   })  

apps/api-gateway/src/verification/verification.controller.ts

@@ -16,7 +16,7 @@ import { Controller, Logger, Post, Body, Get, Query, HttpStatus, Res, UseGuards,
 import { ApiResponseDto } from '../dtos/apiResponse.dto';
 import { UnauthorizedErrorDto } from '../dtos/unauthorized-error.dto';
 import { ForbiddenErrorDto } from '../dtos/forbidden-error.dto';
-import { SendProofRequestPayload, RequestProofDto, ProofRequestPayloadDto } from './dto/request-proof.dto';
+import { SendProofRequestPayload, RequestProofDtoV1, RequestProofDtoV2 } from './dto/request-proof.dto';
 import { VerificationService } from './verification.service';
 import IResponseType, { IResponse } from '@credebl/common/interfaces/response.interface';
 import { Response } from 'express';
@@ -171,7 +171,7 @@ export class VerificationController {
     @ApiResponse({ status: HttpStatus.OK, description: 'Success', type: ApiResponseDto })
     @ApiUnauthorizedResponse({ status: HttpStatus.UNAUTHORIZED, description: 'Unauthorized', type: UnauthorizedErrorDto })
     @ApiForbiddenResponse({ status: HttpStatus.FORBIDDEN, description: 'Forbidden', type: ForbiddenErrorDto })
-    @ApiBody({ type: RequestProofDto })@ApiQuery({
+    @ApiBody({ type: RequestProofDtoV1 })@ApiQuery({
         name: 'requestType',
         enum: ProofRequestType
       })
@@ -182,7 +182,7 @@ export class VerificationController {
         @Res() res: Response,
         @User() user: IUserRequest,
         @Param('orgId', new ParseUUIDPipe({exceptionFactory: (): Error => { throw new BadRequestException(`Invalid format for orgId`); }})) orgId: string,
-        @Body() requestProof: RequestProofDto,
+        @Body() requestProof: RequestProofDtoV1,
         @Query('requestType') requestType:ProofRequestType = ProofRequestType.INDY
     ): Promise<Response> {
 
@@ -233,7 +233,7 @@ export class VerificationController {
     @ApiResponse({ status: HttpStatus.OK, description: 'Success', type: ApiResponseDto })
     @ApiUnauthorizedResponse({ status: HttpStatus.UNAUTHORIZED, description: 'Unauthorized', type: UnauthorizedErrorDto })
     @ApiForbiddenResponse({ status: HttpStatus.FORBIDDEN, description: 'Forbidden', type: ForbiddenErrorDto })
-    @ApiBody({ type: ProofRequestPayloadDto })@ApiQuery({
+    @ApiBody({ type: RequestProofDtoV2 })@ApiQuery({
         name: 'requestType',
         enum: ProofRequestType
       })
@@ -244,7 +244,7 @@ export class VerificationController {
         @Res() res: Response,
         @User() user: IUserRequest,
         @Param('orgId', new ParseUUIDPipe({exceptionFactory: (): Error => { throw new BadRequestException(`Invalid format for orgId`); }})) orgId: string,
-        @Body() requestProof: ProofRequestPayloadDto,
+        @Body() requestProof: RequestProofDtoV2,
         @Query('requestType') requestTypeV1:ProofRequestType = ProofRequestType.INDY
     ): Promise<Response> {
 

apps/api-gateway/src/verification/verification.service.ts

@@ -1,7 +1,7 @@
 import { Injectable, Inject} from '@nestjs/common';
 import { ClientProxy} from '@nestjs/microservices';
 import { BaseService } from 'libs/service/base.service';
-import { SendProofRequestPayload, RequestProofDto, ProofRequestPayloadDto } from './dto/request-proof.dto';
+import { SendProofRequestPayload, RequestProofDtoV1, RequestProofDtoV2 } from './dto/request-proof.dto';
 import { IUserRequest } from '@credebl/user-request/user-request.interface';
 import { WebhookPresentationProofDto } from './dto/webhook-proof.dto';
 import { IProofPresentationDetails, IProofPresentationList, IVerificationRecords } from '@credebl/common/interfaces/verification.interface';
@@ -47,7 +47,7 @@ export class VerificationService extends BaseService {
      * @param orgId 
      * @returns Requested proof presentation details
      */
-    sendProofRequest(requestProofDto: RequestProofDto | ProofRequestPayloadDto, user: IUserRequest): Promise<IProofRequest> {
+    sendProofRequest(requestProofDto: RequestProofDtoV1 | RequestProofDtoV2, user: IUserRequest): Promise<IProofRequest> {
         const payload = { requestProofDto, user };
         return this.natsClient.sendNatsMessage(this.verificationServiceProxy, 'send-proof-request', payload);
     }