fix: resolved coderabbit suggested chnages

Signed-off-by: Rinkal Bhojani <[email protected]>

Author: RinkalBhojani

apps/api-gateway/src/agent-service/dto/create-schema.dto.ts

@@ -21,6 +21,8 @@ export class CreateTenantSchemaDto {
   @IsArray({ message: 'attributes must be an array' })
   @IsString({ each: true })
   // TODO: IsNotEmpty won't work for array. Must use @ArrayNotEmpty() instead
+  // @ArrayNotEmpty({ message: 'please provide at least one attribute' })
+  // @IsNotEmpty({ each: true, message: 'attribute must not be empty' })
   @IsNotEmpty({ message: 'please provide valid attributes' })
   attributes: string[];
 

apps/api-gateway/src/oid4vc-issuance/dtos/issuer-sessions.dto.ts

@@ -17,7 +17,8 @@ import {
   ValidatorConstraint,
   ValidatorConstraintInterface,
   ValidationArguments,
-  Validate
+  Validate,
+  IsDate
 } from 'class-validator';
 import { ApiProperty, ApiPropertyOptional } from '@nestjs/swagger';
 import { Type } from 'class-transformer';
@@ -123,16 +124,18 @@ export class ValidityInfo {
     example: '2025-04-23T14:34:09.188Z',
     required: true
   })
-  @IsString()
   @IsNotEmpty()
+  @Type(() => Date)
+  @IsDate()
   validFrom: Date;
 
   @ApiProperty({
     example: '2026-05-03T14:34:09.188Z',
     required: true
   })
-  @IsString()
   @IsNotEmpty()
+  @Type(() => Date)
+  @IsDate()
   validUntil: Date;
 }
 

apps/api-gateway/src/oid4vc-issuance/dtos/oid4vc-issuer-template.dto.ts

@@ -15,7 +15,7 @@ import {
 import { ApiExtraModels, ApiProperty, ApiPropertyOptional, getSchemaPath, PartialType } from '@nestjs/swagger';
 import { Type } from 'class-transformer';
 import { SignerOption } from '@prisma/client';
-import { CredentialFormat } from '@credebl/enum/enum';
+import { AttributeType, CredentialFormat } from '@credebl/enum/enum';
 
 class CredentialAttributeDisplayDto {
   @ApiPropertyOptional({ example: 'First Name' })
@@ -28,17 +28,6 @@ class CredentialAttributeDisplayDto {
   @IsOptional()
   locale?: string;
 }
-
-export enum AttributeType {
-  STRING = 'string',
-  NUMBER = 'number',
-  BOOLEAN = 'boolean',
-  DATE = 'date',
-  OBJECT = 'object',
-  ARRAY = 'array',
-  IMAGE = 'image'
-}
-
 export class CredentialAttributeDto {
   @ApiProperty({ description: 'Unique key for this attribute (e.g., full_name, org.iso.23220.photoID.1.birth_date)' })
   @IsString()
@@ -52,7 +41,8 @@ export class CredentialAttributeDto {
   // TODO: Check how do we handle claims with only path rpoperty like email, etc.
   @ApiProperty({ enum: AttributeType, description: 'Type of the attribute value (string, number, date, etc.)' })
   @IsEnum(AttributeType)
-  value_type: string;
+  // TODO: changes value_type: AttributeType;
+  value_type: AttributeType;
 
   @ApiProperty({ description: 'Whether this attribute should be disclosed (for SD-JWT)' })
   @IsOptional()
@@ -210,6 +200,8 @@ export class SdJwtTemplateDto {
     description: 'Attributes included in the credential template'
   })
   @IsArray()
+  @ValidateNested({ each: true })
+  @Type(() => CredentialAttributeDto)
   attributes: CredentialAttributeDto[];
 }
 

apps/oid4vc-issuance/interfaces/oid4vc-template.interfaces.ts

@@ -1,5 +1,5 @@
 import { Prisma, SignerOption } from '@prisma/client';
-import { CredentialFormat } from '@credebl/enum/enum';
+import { AttributeType, CredentialFormat } from '@credebl/enum/enum';
 export interface SdJwtTemplate {
   vct: string;
   attributes: CredentialAttribute[];
@@ -40,7 +40,7 @@ export interface Claim {
 export interface CredentialAttribute {
   key: string;
   mandatory?: boolean;
-  value_type: string;
+  value_type: AttributeType;
   disclose?: boolean;
   children?: CredentialAttribute[];
   display?: ClaimDisplay[];

libs/common/src/date-only.ts

@@ -2,8 +2,25 @@ const customInspectSymbol = Symbol.for('nodejs.util.inspect.custom');
 export class DateOnly {
   private date: Date;
 
-  public constructor(date?: string) {
-    this.date = date ? new Date(date) : new Date();
+  public constructor(date?: string | Date) {
+    if (date instanceof Date) {
+      if (isNaN(date.getTime())) {
+        throw new TypeError('Invalid Date');
+      }
+      this.date = date;
+      return;
+    }
+    if (!date) {
+      this.date = new Date();
+      return;
+    }
+    // Accept only YYYY-MM-DD or full ISO strings
+    const iso = /^\d{4}-\d{2}-\d{2}(T.*Z)?$/.test(date) ? date : '';
+    const d = new Date(iso || date);
+    if (isNaN(d.getTime())) {
+      throw new TypeError('Invalid date string');
+    }
+    this.date = d;
   }
 
   get [Symbol.toStringTag](): string {
@@ -34,5 +51,8 @@ export const serverStartupTimeInMilliseconds = Date.now();
 
 export function dateToSeconds(date: Date | DateOnly): number {
   const realDate = date instanceof DateOnly ? new Date(date.toISOString()) : date;
+  if (isNaN(realDate.getTime())) {
+    throw new TypeError('dateToSeconds: invalid date');
+  }
   return Math.floor(realDate.getTime() / 1000);
 }

libs/enum/src/enum.ts

@@ -323,6 +323,16 @@ export enum CredentialFormat {
   Mdoc = 'mso_mdoc'
 }
 
+export enum AttributeType {
+  STRING = 'string',
+  NUMBER = 'number',
+  BOOLEAN = 'boolean',
+  DATE = 'date',
+  OBJECT = 'object',
+  ARRAY = 'array',
+  IMAGE = 'image'
+}
+
 // export enum SignerOption {
 //   DID,
 //   X509_P256,