-
Notifications
You must be signed in to change notification settings - Fork 64
feat: SSO support and clientcredentials based switchig for single sign on feature #1183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
e55d113
5e3b4bb
3b91a03
1e4943f
971a8d5
967291c
b92e2fc
c001f78
81eccb7
2bf9db7
6a8fdbd
0fa120f
d979119
710ef7e
a9d3638
8de48be
3235a88
e4a50f3
d513ed1
f577aec
9cd6c1f
317fde5
91e5052
4951f72
f587f3a
3696153
e82bc4e
9741141
d08dda7
1ce79c1
5d3c18e
8063050
2e32d67
2db9c8c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -70,4 +70,4 @@ body: | |
- Docs updated | ||
- Tests written and passing | ||
validations: | ||
required: false | ||
required: false | ||
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
|
@@ -87,4 +87,4 @@ body: | |||||||
- Console output | ||||||||
- Stack traces | ||||||||
validations: | ||||||||
required: false | ||||||||
required: false | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Restore trailing newline to avoid YAMLlint failure Same issue as in the feature-request template—lack of a terminal newline violates lint rules and standard tooling expectations. validations:
required: false
+ 📝 Committable suggestion
Suggested change
🧰 Tools🪛 YAMLlint (1.37.1)[error] 90-90: no new line character at the end of file (new-line-at-end-of-file) 🤖 Prompt for AI Agents
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,17 +1,6 @@ | ||
import { PrismaService } from '@credebl/prisma-service'; | ||
/* eslint-disable camelcase */ | ||
import { AgentType, PrismaTables } from '@credebl/enum/enum'; | ||
import { ConflictException, Injectable, Logger } from '@nestjs/common'; | ||
// eslint-disable-next-line camelcase | ||
import { | ||
Prisma, | ||
ledgerConfig, | ||
ledgers, | ||
org_agents, | ||
org_agents_type, | ||
org_dids, | ||
organisation, | ||
platform_config, | ||
user | ||
} from '@prisma/client'; | ||
import { | ||
ICreateOrgAgent, | ||
ILedgers, | ||
|
@@ -24,7 +13,19 @@ import { | |
LedgerNameSpace, | ||
OrgDid | ||
} from '../interface/agent-service.interface'; | ||
import { AgentType, PrismaTables } from '@credebl/enum/enum'; | ||
import { | ||
Prisma, | ||
ledgerConfig, | ||
ledgers, | ||
org_agents, | ||
org_agents_type, | ||
org_dids, | ||
organisation, | ||
platform_config, | ||
user | ||
} from '@prisma/client'; | ||
Comment on lines
+16
to
+26
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion Mark Prisma model imports as type-only to prevent accidental runtime usage -import {
- Prisma,
- ledgerConfig,
- ledgers,
- org_agents,
- org_agents_type,
- org_dids,
- organisation,
- platform_config,
- user
-} from '@prisma/client';
+import type {
+ Prisma,
+ ledgerConfig,
+ ledgers,
+ org_agents,
+ org_agents_type,
+ org_dids,
+ organisation,
+ platform_config,
+ user
+} from '@prisma/client'; Using 🤖 Prompt for AI Agents
|
||
|
||
import { PrismaService } from '@credebl/prisma-service'; | ||
|
||
@Injectable() | ||
export class AgentServiceRepository { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-add missing trailing newline to satisfy YAMLlint & POSIX text-file convention
Removing the final newline triggers the YAMLlint
new-line-at-end-of-file
error and can break CI pipelines that enforce linting. All text files should terminate with a single\n
.validations: required: false +
📝 Committable suggestion
🧰 Tools
🪛 YAMLlint (1.37.1)
[error] 73-73: no new line character at the end of file
(new-line-at-end-of-file)
🤖 Prompt for AI Agents